Skip to content
This repository has been archived by the owner. It is now read-only.

LIFX: Fix #3745 powerOnBrightness is ignored when empty in the things file #3772

Merged
merged 1 commit into from Jun 30, 2017
Merged

LIFX: Fix #3745 powerOnBrightness is ignored when empty in the things file #3772

merged 1 commit into from Jun 30, 2017

Conversation

@wborn
Copy link
Contributor

@wborn wborn commented Jun 29, 2017

As reported in #3745 using powerOnBrightness= in a .things file no longer works. Such files nowadays fail validation, e.g. the following warning is logged:

19:04:22.457 [WARN ] [el.core.internal.ModelRepositoryImpl] - Configuration model 'test.things' has errors, therefore ignoring it: [4,49]: no viable alternative at input ']'

After testing it shows that removing the default for the powerOnBrightness parameter makes it again possible to switch lights on without changing the brightness when the powerOnBrightness parameter in .things files is omitted.

… file

Signed-off-by: Wouter Born <eclipse@maindrain.net>
Copy link
Contributor

@kaikreuzer kaikreuzer left a comment

Makes indeed much more sense, thanks!

@kaikreuzer kaikreuzer merged commit 2565ad7 into eclipse-archived:master Jun 30, 2017
2 checks passed
@wborn wborn deleted the 3745-lifx-bugfix branch Jun 30, 2017
@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Nov 30, 2017
@kaikreuzer kaikreuzer added the bug label Dec 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants