Skip to content
This repository has been archived by the owner. It is now read-only.

Break circle dependency in GroupItem members #3795

Merged

Conversation

@triller-telekom
Copy link
Contributor

@triller-telekom triller-telekom commented Jul 4, 2017

Fixes #3794

Signed-off-by: Stefan Triller stefan.triller@telekom.de

@@ -116,6 +116,9 @@ public GroupFunction getFunction() {

private void collectMembers(Set<Item> allMembers, Set<Item> members) {
for (Item member : members) {
if (allMembers.contains(member)) {
return;
Copy link
Contributor

@sjsf sjsf Jul 4, 2017

how about continue instead of return? 😉

Copy link
Contributor Author

@triller-telekom triller-telekom Jul 4, 2017

Just noticed that and changed the code but your continue is even better ;)

Well... that is only if I swap the allMembers.put and the recursive call too... So I think the if I have used now should be fine

@triller-telekom triller-telekom force-pushed the groupItemCircleDependency branch from 6024db6 to c88d449 Jul 4, 2017
Fixes eclipse-archived#3794

Signed-off-by: Stefan Triller <stefan.triller@telekom.de>
@triller-telekom triller-telekom force-pushed the groupItemCircleDependency branch from c88d449 to 9014da6 Jul 4, 2017
sjsf
sjsf approved these changes Jul 4, 2017
Copy link
Contributor

@sjsf sjsf left a comment

Much better, thanks!

@sjsf sjsf merged commit 1f6dd6d into eclipse-archived:master Jul 4, 2017
2 checks passed
@triller-telekom triller-telekom deleted the groupItemCircleDependency branch Jul 5, 2017
@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Nov 30, 2017
@kaikreuzer kaikreuzer added the bug label Dec 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants