Skip to content
This repository has been archived by the owner. It is now read-only.

Sonos binding: add state description on few channels #3800

Merged
merged 1 commit into from Jul 25, 2017
Merged

Sonos binding: add state description on few channels #3800

merged 1 commit into from Jul 25, 2017

Conversation

@lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Jul 4, 2017

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo
Copy link
Contributor Author

@lolodomo lolodomo commented Jul 5, 2017

Please wait for the end of discussion in the issue. Maybe this PR is not necessary if I provide a more general solution.

@sjsf
Copy link
Contributor

@sjsf sjsf commented Jul 6, 2017

just adding the "feedback" label to mark it as blocked

@lolodomo
Copy link
Contributor Author

@lolodomo lolodomo commented Jul 6, 2017

I propose to merge it before the next release if no general fix is merged at this time.

@lolodomo
Copy link
Contributor Author

@lolodomo lolodomo commented Jul 10, 2017

This PR may be closed and abandoned when #3822 is merged.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo changed the title Sonos binding: add a default pattern to string and number channels Sonos binding: add state description on few channels Jul 17, 2017
@lolodomo
Copy link
Contributor Author

@lolodomo lolodomo commented Jul 17, 2017

@SJKA : I changed the focus of this PR to simply add a state description on channels that require one (mainly for read-only channels) and reorder the channels in alphabetic order (few of them were previously added by me at the end of the file).

Copy link
Contributor

@kaikreuzer kaikreuzer left a comment

Lgtm, thanks!

@kaikreuzer kaikreuzer merged commit 2bc0584 into eclipse-archived:master Jul 25, 2017
2 checks passed
@lolodomo lolodomo deleted the sonos_pattern branch Jul 25, 2017
@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Nov 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants