Skip to content
This repository has been archived by the owner. It is now read-only.

[astro] Tidy up set of scheduled futures #3811

Merged
merged 1 commit into from Jul 7, 2017

Conversation

@sjsf
Copy link
Contributor

@sjsf sjsf commented Jul 6, 2017

...in order to not keep useless references to finished jobs in the collections.

It's taking the opportunity for tidying up every time a new job gets scheduled.
In that way, the job's runnables don't have to be cluttered with these
internals of the handler.

Note: while it is in principle is similar to #3809, the current version since #3776 does not cause such troubles anymore. So this PR is mainly about freeing a little bit of memory.

Signed-off-by: Simon Kaufmann simon.kfm@googlemail.com

...in order to not keep useless references to finished jobs in the collections.

It's taking the opportunity for tyding up every time a new job gets scheduled.
In that way, the job's runnables don't have to be cluttered with these
internals of the handler.

Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
Copy link
Contributor

@triller-telekom triller-telekom left a comment

LGTM

@kaikreuzer kaikreuzer merged commit 8af6f61 into eclipse-archived:master Jul 7, 2017
2 checks passed
@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Nov 30, 2017
@kaikreuzer kaikreuzer added the bug label Dec 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants