Skip to content
This repository has been archived by the owner. It is now read-only.

Sonos binding: handle Google Play Music radio #3940

Merged
merged 2 commits into from Aug 9, 2017
Merged

Sonos binding: handle Google Play Music radio #3940

merged 2 commits into from Aug 9, 2017

Conversation

@lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Aug 3, 2017

Fix #3937

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo
Copy link
Contributor Author

@lolodomo lolodomo commented Aug 3, 2017

Please wait, I think I made an unnecessary (wrong) distinction between tunein radio and GPM radio when handling sound notification s.

Fix #3937

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo
Copy link
Contributor Author

@lolodomo lolodomo commented Aug 3, 2017

Change done; ready for review and merge.

@lolodomo
Copy link
Contributor Author

@lolodomo lolodomo commented Aug 3, 2017

Travis is failing in Eclipse SmartHome Core Binding XML Tests on something that cannot have a link with my current change.

In my local environment, the Maven build is failing earlier in Eclipse SmartHome Core Tests with something else without any link with my change? I will open an issue for that.

@lolodomo
Copy link
Contributor Author

@lolodomo lolodomo commented Aug 4, 2017

@kgoderis : any chance that you review this little change ?

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@maggu2810
Copy link
Contributor

@maggu2810 maggu2810 commented Aug 9, 2017

@kgoderis : any chance that you review this little change ?

I don't think so. See here: #3912 (comment)

@maggu2810 maggu2810 merged commit fa773e8 into eclipse-archived:master Aug 9, 2017
1 check passed
@lolodomo lolodomo deleted the sonos_gpm branch Aug 9, 2017
@lolodomo
Copy link
Contributor Author

@lolodomo lolodomo commented Aug 9, 2017

Thank you

@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Nov 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants