Skip to content
This repository has been archived by the owner. It is now read-only.

Sonos: play TuneIn by a station id #4229

Merged
merged 1 commit into from Sep 16, 2017
Merged

Sonos: play TuneIn by a station id #4229

merged 1 commit into from Sep 16, 2017

Conversation

@lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Sep 9, 2017

Channel table fully updated in the documentation with the access mode added for each channel

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo
Copy link
Contributor Author

@lolodomo lolodomo commented Sep 11, 2017

@kgoderis : could you please review this change ?

Copy link
Contributor

@kaikreuzer kaikreuzer left a comment

Code lgtm, would be nice to have some feedback from @kgoderis or @wborn if it also works as expected, before we merge it.

@sjsf
Copy link
Contributor

@sjsf sjsf commented Sep 15, 2017

Just tried it out - works like a charm for me 👍

sjsf
sjsf approved these changes Sep 15, 2017
@@ -132,6 +134,8 @@

private Map<String, String> stateMap = Collections.synchronizedMap(new HashMap<String, String>());

private List<SonosMusicService> msuicServices;
Copy link
Contributor

@wborn wborn Sep 15, 2017

I don't own or use any Sonos devices. But "msuicServices" looks like a typo. :-)

Copy link
Contributor

@kaikreuzer kaikreuzer Sep 15, 2017

Good catch :-)
Ah, sorry, don't know where my head is these days... I somehow mixed up Sonos with LIFX... So forget about my testing request unless you can make your bulbs play some music 🤣

Copy link
Contributor Author

@lolodomo lolodomo Sep 15, 2017

lol

Channel table fully updated in the documentation with the access mode added for each channel

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo
Copy link
Contributor Author

@lolodomo lolodomo commented Sep 15, 2017

Typo fixed + everything squashed.

@maggu2810 maggu2810 merged commit 47de57e into eclipse-archived:master Sep 16, 2017
2 checks passed
@lolodomo lolodomo deleted the sonos_tunein branch Sep 16, 2017
@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Nov 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants