Skip to content
This repository has been archived by the owner. It is now read-only.

[UI] Charts Enhancements: Themes, DPI, legend hiding #4291

Merged

Conversation

@hreichert
Copy link
Contributor

@hreichert hreichert commented Sep 17, 2017

Add some enhancements to the ChartServlet, DefaultChartProvider, REST API, BasicUI/ClassicUI to support the following things:

  • Chart themes for different looks
  • dpi parameter for dynamic sizes based on DPI
  • Automatic showing/hiding of the legend based on number of chart series
  • legend parameter to hide/show the chart legend

Please see issue #4288 for all details.
The first comment has a up2date description.

This breaks the OH1 compatibility layer: org.openhab.ui.chart.internal.ChartProviderDelegate
If this gets merged, I create a PR in openhab/openhab-core


Renderings
Default theme "bright", default settings:
chart_1
Theme "dark", default settings:
chart_2
Theme "black", default settings:
chart_3

@hreichert hreichert force-pushed the 4288-charts-enhancements branch 3 times, most recently from 575dddc to e14c21f Sep 21, 2017
@hreichert hreichert changed the title [WIP] [Charts] Enhancements to Charts: Themes, FontScale, HideLegend (#4288) [UI] Charts Enhancements: Themes, DPI, legend hiding Sep 21, 2017
@hreichert hreichert force-pushed the 4288-charts-enhancements branch from e14c21f to 0d743a2 Sep 21, 2017
@kaikreuzer kaikreuzer added the UI label Sep 22, 2017
Copy link
Contributor

@kaikreuzer kaikreuzer left a comment

Many thanks, looks all perfect!

@kaikreuzer kaikreuzer merged commit 4dd53d9 into eclipse-archived:master Sep 25, 2017
2 checks passed
@hreichert hreichert deleted the 4288-charts-enhancements branch Sep 25, 2017
@hreichert
Copy link
Contributor Author

@hreichert hreichert commented Sep 25, 2017

Thank you @kaikreuzer

@kaikreuzer
Copy link
Contributor

@kaikreuzer kaikreuzer commented Sep 25, 2017

Time to prepare the PR for openhab-core now :-)

@hreichert
Copy link
Contributor Author

@hreichert hreichert commented Sep 25, 2017

Sure, here you go: openhab/openhab-core#215
But the travis build for this commit will not succeed now...

mueller-ma added a commit to mueller-ma/openhab.android that referenced this issue Sep 29, 2017
This commit enhances charts to support themes, scale legend according to
dpi and create option to hide legend

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
mueller-ma added a commit to mueller-ma/openhab.android that referenced this issue Sep 30, 2017
This commit enhances charts to support themes, scale legend according to
dpi and create option to hide legend

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
digitaldan added a commit to openhab/openhab-android that referenced this issue Oct 8, 2017
* Make use of eclipse-archived/smarthome#4291

This commit enhances charts to support themes, scale legend according to
dpi and create option to hide legend

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

* Read legend setting from oh server

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

* Use Boolean

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Nov 30, 2017
@openhab-bot
Copy link
Contributor

@openhab-bot openhab-bot commented May 21, 2018

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/charts-are-not-working-as-before-anymore-broken/41208/41

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants