Skip to content
This repository has been archived by the owner. It is now read-only.

[BasicUI] Integrate ChartThemes in BasicUI themes #4336

Merged

Conversation

@hreichert
Copy link
Contributor

@hreichert hreichert commented Sep 25, 2017

This PR integrates chart themes to the BasicUI.

  • #4137 introduced BasicUI themes
  • #4291 introduced chart themes

Take a matching ChartTheme for the current BasicUI theme:

  • If the dark theme is choosen in BasicUI, render a dark chart.
  • If the default theme is choosen in BasicUI, render a bright chart.

As the bright chart theme has the same colors as the previous/current chart, there is no change if someone uses the default BasicUI theme.

BasicUI default:
basicui_chart_default

BasicUI dark:
basicui_chart_dark

Take a matching ChartTheme for the current BasicUI theme.

Signed-off-by: Holger Reichert <mail@h0lger.de>
Copy link
Contributor

@kaikreuzer kaikreuzer left a comment

Excellent, thanks!

@kaikreuzer kaikreuzer merged commit e135552 into eclipse-archived:master Sep 26, 2017
2 checks passed
@hreichert hreichert deleted the basicui-chart-theme-integration branch Sep 26, 2017
@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Nov 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants