Skip to content
This repository has been archived by the owner. It is now read-only.

Add support for Sonos One player #4429

Merged
merged 1 commit into from Oct 23, 2017
Merged

Add support for Sonos One player #4429

merged 1 commit into from Oct 23, 2017

Conversation

@ivivanov-bg
Copy link
Contributor

@ivivanov-bg ivivanov-bg commented Oct 17, 2017

Add support for Sonos One player

Signed-off-by: Ivaylo Ivanov ivivanov.bg@gmail.com

xsi:schemaLocation="http://eclipse.org/smarthome/schemas/thing-description/v1.0.0 http://eclipse.org/smarthome/schemas/thing-description-1.0.0.xsd">

<!-- Player ONE Thing Type -->
<thing-type id="One" listed="false">
Copy link
Contributor

@kaikreuzer kaikreuzer Oct 17, 2017

Shouldn't this be better "ONE" in capitals (to be in sync with the PLAYXs?

Copy link
Contributor Author

@ivivanov-bg ivivanov-bg Oct 17, 2017

Well - it could be - but the the discovery has to be tuned too because the player announces itself as 'One' and not 'ONE'

Copy link
Contributor

@lolodomo lolodomo Oct 17, 2017

The discovery code could ignore the case.

Copy link
Contributor

@kaikreuzer kaikreuzer Oct 17, 2017

I'd agree that it would be better to harden the discovery code.

The real Name of Play 1 is "PLAY:1" and the real name of the one is "One" and NOT "ONE". So i recommend to use the real name for the ID. Sonos changed their pattern: http://www.sonos.com/de-de/shop/one.html

Copy link
Contributor

@kaikreuzer kaikreuzer Oct 21, 2017

Ok, but then these lines are clearly wrong in the first place: https://github.com/eclipse/smarthome/pull/4429/files#diff-148f59c83d8c2a479dea48c22dd67b70R10

Copy link
Contributor

@lolodomo lolodomo left a comment

Please add new entries in the translation files, somethiong similar to
thing-type.sonos.CONNECT.label = CONNECT
thing-type.sonos.CONNECT.description = Représente un lecteur pré-ampli Sonos CONNECT
If you don't know how to translate, put the line in comments.

<channel id="sleeptimer" typeId="sleeptimer" />
<channel id="currenttransporturi" typeId="currenttransporturi" />
<channel id="currenttrackuri" typeId="currenttrackuri" />
</channels>
Copy link
Contributor

@lolodomo lolodomo Oct 21, 2017

Is there no line-in in the One ? If line-in is present, take example on the PLAY:5.

@lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Oct 21, 2017

If "One" is kept as thing type id, there is nothing to change in the discovery code.
Please add the following lines in the french translation:
thing-type.sonos.One.label = One
thing-type.sonos.One.description = Représente une enceinte Sonos One

Copy link
Contributor

@kaikreuzer kaikreuzer left a comment

Please make sure to use the correct spelling "One" throughout the PR, especially in user facing texts.

Signed-off-by: Ivaylo Ivanov <ivivanov.bg@gmail.com>
@kaikreuzer kaikreuzer merged commit 4049898 into eclipse-archived:master Oct 23, 2017
2 checks passed
hsudbrock added a commit to hsudbrock/smarthome that referenced this issue Oct 24, 2017
Signed-off-by: Ivaylo Ivanov <ivivanov.bg@gmail.com>
@ivivanov-bg ivivanov-bg deleted the add_support_for_sonos_one branch Nov 3, 2017
@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Nov 30, 2017
@openhab-bot
Copy link
Contributor

@openhab-bot openhab-bot commented Feb 10, 2018

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/sonos-one-discovered-as-zoneplayer-solved/39834/3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants