Improve Breakpoint Error Logging #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addresses part 1) of #402 |
jreineckearm
approved these changes
Jul 17, 2025
There was a problem hiding this comment.
LGTM! Apologies for applying review feedback myself. @omarArm is out for a couple of days.
I think switchOutputToError will evolve over time. I suspect there is more severe errors hidden in the blue logs. Improve the error transformation code when adding more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When a user is using remote GDB and tries to set more than the amount of HW breakpoints, GDB sends a warning message and cannot step anymore.
Solution:
I created this PR, where a red error message will be printed to the user to ask for the extra breakpoints to be erased.
Future work:
When the user sets all of the breakpoints before starting the debug session the adapter sends an error message to VSCode, which in turn triggers a disconnect request back to the adapter. This should be mitigated somehow for a consistent behaviour between before and after the debug session starts