Build Type combo value update oddly

[DangMinhTam382]

The value in Build type combo keeps being update back and forward the type-in value

[DangMinhTam382]

Since combo does not has modifyListener, this value is not being saved when typing in combo.
When switching back to BuildSettings tab, the value reverted to the old value. And in the second switching back, the new value appears.
The reason for this was, when restoreProperties(Map<String, String> properties) is called:

cdt/cmake/org.eclipse.cdt.cmake.ui/src/org/eclipse/cdt/cmake/ui/internal/CMakeBuildTab.java

Lines 271 to 304 in fd56a4e

	@Override
	protected void restoreProperties(Map<String, String> properties) {
	super.restoreProperties(properties);
	String gen = properties.getOrDefault(CMakeBuildConfiguration.CMAKE_GENERATOR,
	CMakeBuildConfiguration.CMAKE_GENERATOR_DEFAULT);
	generatorCombo.setText(gen);
	String cmakeArgs = properties.getOrDefault(CMakeBuildConfiguration.CMAKE_ARGUMENTS,
	CMakeBuildConfiguration.CMAKE_ARGUMENTS_DEFAULT);
	cmakeArgsText.setText(cmakeArgs);
	String buildCmd = properties.getOrDefault(CMakeBuildConfiguration.CMAKE_BUILD_COMMAND,
	CMakeBuildConfiguration.CMAKE_BUILD_COMMAND_DEFAULT);
	buildCommandText.setText(buildCmd);
	String allTarget = properties.getOrDefault(CMakeBuildConfiguration.CMAKE_ALL_TARGET,
	CMakeBuildConfiguration.CMAKE_ALL_TARGET_DEFAULT);
	allTargetText.setText(allTarget);
	String cleanTarget = properties.getOrDefault(CMakeBuildConfiguration.CMAKE_CLEAN_TARGET,
	CMakeBuildConfiguration.CMAKE_CLEAN_TARGET_DEFAULT);
	cleanTargetText.setText(cleanTarget);
	// Default build type: Debug for Debug launch mode, Release for Run and other launch modes.
	String defaultBuildType = getDefaultBuildType();
	String buildType = properties.getOrDefault(CMakeBuildConfiguration.CMAKE_BUILD_TYPE, defaultBuildType);
	buildTypeCombo.setText(buildType);
	ILaunchMode launchMode = DebugPlugin.getDefault().getLaunchManager()
	.getLaunchMode(getBuildConfiguration().getLaunchMode());
	String launchModeLabel = launchMode != null ? launchMode.getLabel() : getBuildConfiguration().getLaunchMode();
	usedForLaunchModeLabel.setText(MessageFormat.format(Messages.CMakeBuildTab_UsedForLaunchMode, launchModeLabel));
	}

Text boxes were being setText() this triggered modifyListener and called performApply() and save the new value to properties (this value get directly from buildTypeCombo.getText().trim()).
When return back to restoreProperties, the properties value here is out-dated, which make buildTypeCombo.setText(oldValue)
In second switch, Old value (Debug) would become new value (MyDebug), vice versa.

Which leads to value being update back and forth

[DangMinhTam382]

This would also happen with generatorCombo, but lucky here, generatorCombo.setText(gen) was call before modifyListener was triggered from cmakeArgsText.setText(cmakeArgs) so it just simply reverted the value back to previous saved value