Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for over-indent on formatter:on tag #431

Closed
wants to merge 1 commit into from
Closed

Fix for over-indent on formatter:on tag #431

wants to merge 1 commit into from

Conversation

jonahgraham
Copy link
Member

For now this is just the test that fails. TODO:

  • fix the formatter

Fixes #428

@jonahgraham jonahgraham mentioned this pull request Jun 20, 2023
Open
@jonahgraham
Fix for over-indent on formatter:on tag
daab459 
This fix does resoved eclipse-cdt#428 - but regresses Bug 559669

TODO:

- [ ] fix the formatter properly

Fixes eclipse-cdt#428
@jonahgraham jonahgraham added good-first-issue A good first issue, generally an easy to test bit of code that runs fairly self-contained. and removed good-first-issue A good first issue, generally an easy to test bit of code that runs fairly self-contained. labels Oct 11, 2023
@jonahgraham
Copy link
Member Author

Rather than maintain this PR, I have added the new tests to the issue and I am closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C/C++ Formatter end suppression (@formatter:on) gets indented
1 participant
@jonahgraham