Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Che-Code CI build more stable when downloading artifacts from api.github.com #22003

Closed
azatsarynnyy opened this issue Feb 15, 2023 · 3 comments
Assignees
Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@azatsarynnyy
Copy link
Member

Is your task related to a problem? Please describe

Che-Code build has external dependencies downloaded from api.github.com.
Often, downloading process is failed with the error:

#12 34.11 GET https://api.github.com/repos/microsoft/ripgrep-prebuilt/releases/tags/v13.0.0-4
#12 34.11 Deleting invalid download cache
#12 34.11 Downloading ripgrep failed: Error: Request failed: 403

For more details, see https://github.com/che-incubator/che-code/actions/runs/4140287034/jobs/7158796952.

It used to be a minor issue for the GitHub Workflow-based CI until we included Che-Code into the overall Che release flow.
During the Che release, Che-Code build error breaks the release process and requires rerunning it.

Describe the solution you'd like

As it's recommended in microsoft/vscode-ripgrep, we set the GITHUB_TOKEN environment variable:

After setting the GITHUB_TOKEN, we haven't noticed any downloading issues for about a week (Feb 2 - Feb 8).
But, after Feb 8, the problem became relevant again.
We need to investigate if the GITHUB_TOKEN environment variable is propagated correctly to microsoft/vscode-ripgrep.

Describe alternatives you've considered

It may be helpful to check how the problem is solved upstream, for microsoft/vscode CI build.

Additional context

https://github.com/microsoft/vscode-ripgrep/blob/bc5cb922416b4ee0aacf4c0252e42ac78c7ed7e9/lib/postinstall.js#L77

@azatsarynnyy azatsarynnyy added kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. area/editor/vscode Issues related to the Code OSS editor of Che labels Feb 15, 2023
@l0rd l0rd mentioned this issue Mar 6, 2023
7 tasks
@mkuznyetsov mkuznyetsov self-assigned this May 3, 2023
@che-bot
Copy link
Contributor

che-bot commented Oct 30, 2023

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 30, 2023
@che-bot che-bot closed this as completed Nov 6, 2023
@azatsarynnyy
Copy link
Member Author

/remove-lifecycle stale

@azatsarynnyy azatsarynnyy added severity/P2 Has a minor but important impact to the usage or development of the system. and removed sprint/current severity/P1 Has a major impact to usage or development of the system. labels Nov 6, 2023
@azatsarynnyy azatsarynnyy reopened this Nov 6, 2023
@che-bot che-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 6, 2023
@che-bot
Copy link
Contributor

che-bot commented May 4, 2024

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 4, 2024
@che-bot che-bot closed this as completed May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants