Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As an Admin, I want to have the possibility to configure a number of replicas for operands from the CR #22067

Closed
ibuziuk opened this issue Mar 17, 2023 · 9 comments
Assignees
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P2 Has a minor but important impact to the usage or development of the system. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Mar 17, 2023

Is your task related to a problem? Please describe

After the removal of dependency on database, it is now possible to run multiple che-servers (and other operands) in parallel. As an Admin, I want to have the possibility to configure a number of replicas for operands from the CR.

Describe the solution you'd like

replicas CR property for each operand e.g.

spec:
  components:
    cheServer:
      deployment:
        replicas: 1
    dashboard:
      deployment:
        replicas: 1
    devfileRegistry:
      deployment:
        replicas: 1
    pluginRegistry:
      deployment:
        replicas: 1

By default, we can opt for 1, but admin can update the CR accordingly with explicit number of replicas for each operand

Describe alternatives you've considered

N / A

Additional context

Related to #7662

@ibuziuk ibuziuk added kind/task Internal things, technical debt, and to-do tasks to be performed. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach labels Mar 17, 2023
@ibuziuk
Copy link
Member Author

ibuziuk commented Mar 17, 2023

@l0rd @tolusha could you please review the proposal? I do think we have the bandwidth to add it in the next 234 sprint but would be great to discuss it and prioritize for the future sprints

@l0rd
Copy link
Contributor

l0rd commented Mar 17, 2023

Thanks @ibuziuk for opening this. I would rather add it under deployment as replica is a deployment spec:

spec:
  components:
    cheServer:
      deployment:
        replicas: 1
    dashboard:
      deployment:
        replicas: 1
    devfileRegistry:
      deployment:
        replicas: 1
    pluginRegistry:
      deployment:
        replicas: 1

@ibuziuk
Copy link
Member Author

ibuziuk commented Mar 17, 2023

thank you for the review 👍 updated description

@amisevsk amisevsk added the severity/P2 Has a minor but important impact to the usage or development of the system. label Mar 17, 2023
@che-bot
Copy link
Contributor

che-bot commented Sep 13, 2023

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 13, 2023
@che-bot che-bot closed this as completed Sep 20, 2023
@achdmbp
Copy link

achdmbp commented Sep 20, 2023

why is this closed ? has this been already addressed in a recent release?

@tolusha tolusha reopened this Sep 21, 2023
@tolusha tolusha added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 21, 2023
@ibuziuk ibuziuk moved this to 📅 Planned in Eclipse Che Team A Backlog Jan 10, 2024
@ibuziuk
Copy link
Member Author

ibuziuk commented Jan 17, 2024

why is this closed? has this been already addressed in a recent release?

This issue is in the project backlog and we are currently working on supporting number of replicas for operands

@tolusha
Copy link
Contributor

tolusha commented Jan 30, 2024

This issue has been solved in a different way.

This PR [1] prevents che-operator to reset the number of replicas on operands update.
To configure the number of replicas, use the HorizontalPodAutoscaler [2] [3]

[1] eclipse-che/che-operator#1804
[2] https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/
[3] https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale-walkthrough/

@ibuziuk
Copy link
Member Author

ibuziuk commented Jan 31, 2024

@deerskindoll could you please review - eclipse-che/che-docs#2676

@ibuziuk ibuziuk reopened this Jan 31, 2024
@ibuziuk ibuziuk moved this from 🚧 In Progress to Ready for Review in Eclipse Che Team A Backlog Jan 31, 2024
@ibuziuk
Copy link
Member Author

ibuziuk commented Feb 8, 2024

blocked by Vale issue, docs PR can not be merged - https://issues.redhat.com/browse/RHDEVDOCS-5906

@tolusha tolusha closed this as completed Feb 14, 2024
@tolusha tolusha moved this from Ready for Review to ✅ Done in Eclipse Che Team A Backlog Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P2 Has a minor but important impact to the usage or development of the system. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach
Projects
None yet
Development

No branches or pull requests

6 participants