Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New cli tools #91

Merged
merged 3 commits into from May 23, 2022
Merged

New cli tools #91

merged 3 commits into from May 23, 2022

Conversation

thijsmie
Copy link
Contributor

This adds a new suite of command line tools to the python backend:

# list the entities discovered on the network
$ cyclonedds ls
# list the applications discovered on the network (once participant-properties are in)
$ cyclonedds ps
# discover and reconstruct the IDL of a topic type
$ cyclonedds typeof topic_name
# discover and subscribe to an arbitrary topic
$ cyclonedds subscribe topic_name

Copy link
Contributor

@eboasson eboasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! From what I can tell there's no hard dependency on eclipse-cyclonedds/cyclonedds#1281, so no need to wait for it.

That means the only comments I have are a typo and wondering how the color scheme works out for people using a light background. I should try that out myself ... I know.

Neither is a reason to not approve this already. Thanks @thijsmie !

cyclonedds/tools/cli/discovery/main.py Outdated Show resolved Hide resolved
@thijsmie
Copy link
Contributor Author

Indeed there is no hard dependency on the participant-properties, given that we can't rely on them always being there anyways it would not be sensible to require them for the tool to work.

As for the color scheme, I have no idea! I have left basically all settings of the wonderful click by @pallets, rich by @willmcgugan and rich-click by @ewels libraries on default and I have good hope that that will 'just work'! I'll see if I can manage a testrun by fiddling with my terminal settings.

@eboasson
Copy link
Contributor

@thijsmie, if pip install --user --upgrade pip now suddenly fails on Windows, I'd say it is unrelated to this PR. As the CI was fine on all platforms until I merged eclipse-cyclonedds/cyclonedds#1281 and neither that nor the changes you made to this PR in response are platform dependent, I'd say the likelihood of this PR introducing any problems on Windows is negligible. As far as I am concerned, this can be merged right now.

@thijsmie
Copy link
Contributor Author

Yeah I don't know what goes on with windows either, I will merge now and hopefully the problem with pip will go away, if not I'll see about changing the way the windows python environment is set up.

@thijsmie thijsmie merged commit ef73b65 into eclipse-cyclonedds:master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants