feat: restrict contract request message to object #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnoweiss
changed the title
arnoweiss
changed the title
jimmarino
approved these changes
Jun 12, 2025
juliapampus
approved these changes
Jun 15, 2025
juliapampus
merged commit 5eb77ae
into
eclipse-dataspace-protocol-base:main
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR narrows down the allowed data structure in the
offerproperty of theContractRequestMessageWhy it does that
A client has no way of knowing if a provider's ParticipantAgent requires a policy of just the id advertised in the catalog. That's why the Consumer must always give the full object anyway.
Further notes
How a Provider handles the message is outside the scope of the spec.
Linked Issue(s)
Closes #142
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.