Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix dead link to architecture principles page. (fixes #1477) #1478

Merged
merged 2 commits into from Jun 14, 2022

Conversation

iwasakims
Copy link
Contributor

@iwasakims iwasakims commented Jun 14, 2022

What this PR changes/adds

fixes dead link in "Etiquette for pull requests" documentation.

Why it does that

as a follow-up of 05af5e4.

Linked Issue(s)

Closes #1477.

Checklist

  • [-] added appropriate tests?
  • [-] performed checkstyle check locally?
  • [-] added/updated copyright headers?
  • [-] documented public classes/methods?
  • [-] added/updated relevant documentation?
  • [-] added relevant details to the changelog? (skip with label no-changelog)
  • [x ] formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

…dc#1477)

Signed-off-by: Masatake Iwasaki <iwasakims@gmail.com>
@paullatzelsperger
Copy link
Member

paullatzelsperger commented Jun 14, 2022

@iwasakims thanks for noticing and fixing. Please make sure to add an appropriate entry in the CHANGELOG.md, under Fixed, also adding the issue number in brackets.

Once that is done, and all checks are green we can merge.

Signed-off-by: Masatake Iwasaki <iwasakims@gmail.com>
@paullatzelsperger paullatzelsperger merged commit 1b4e718 into eclipse-edc:main Jun 14, 2022
@juliapampus juliapampus added this to In progress in Connector via automation Jun 24, 2022
@juliapampus juliapampus moved this from In progress to Done in Connector Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Connector
  
Done
Development

Successfully merging this pull request may close these issues.

Docs: fix dead link to architecture principles page
2 participants