diff --git a/connectivity/service/src/main/java/org/eclipse/ditto/connectivity/service/ConnectivityRootActor.java b/connectivity/service/src/main/java/org/eclipse/ditto/connectivity/service/ConnectivityRootActor.java index f543f288ff..f80e5f547a 100644 --- a/connectivity/service/src/main/java/org/eclipse/ditto/connectivity/service/ConnectivityRootActor.java +++ b/connectivity/service/src/main/java/org/eclipse/ditto/connectivity/service/ConnectivityRootActor.java @@ -75,6 +75,7 @@ private ConnectivityRootActor(final ConnectivityConfig connectivityConfig, final ClusterConfig clusterConfig = connectivityConfig.getClusterConfig(); final ActorSystem actorSystem = getContext().system(); + final Config config = actorSystem.settings().config(); final ActorRef commandForwarder = getCommandForwarder(clusterConfig, pubSubMediator); @@ -101,7 +102,6 @@ private ConnectivityRootActor(final ConnectivityConfig connectivityConfig, startConnectionShardRegion(actorSystem, connectionSupervisorProps, clusterConfig), connectivityConfig.getPingConfig(), mongoReadJournal), PersistencePingActor.ACTOR_NAME); - final Config config = actorSystem.settings().config(); final ConnectionIdsRetrievalConfig connectionIdsRetrievalConfig = connectivityConfig.getConnectionIdsRetrievalConfig(); final ActorRef connectionIdsRetrievalActor = startChildActor( diff --git a/connectivity/service/src/main/java/org/eclipse/ditto/connectivity/service/mapping/ConnectivitySignalEnrichmentProvider.java b/connectivity/service/src/main/java/org/eclipse/ditto/connectivity/service/mapping/ConnectivitySignalEnrichmentProvider.java index fc80c00d86..27ce3938b9 100644 --- a/connectivity/service/src/main/java/org/eclipse/ditto/connectivity/service/mapping/ConnectivitySignalEnrichmentProvider.java +++ b/connectivity/service/src/main/java/org/eclipse/ditto/connectivity/service/mapping/ConnectivitySignalEnrichmentProvider.java @@ -46,6 +46,7 @@ public interface ConnectivitySignalEnrichmentProvider extends DittoExtensionPoin * Load a {@code ConnectivitySignalEnrichmentProvider} dynamically according to the streaming configuration. * * @param actorSystem The actor system in which to load the facade provider class. + * @param config the config the extension is configured. * @return The configured facade provider. */ static ConnectivitySignalEnrichmentProvider get(final ActorSystem actorSystem, final Config config) { diff --git a/connectivity/service/src/main/java/org/eclipse/ditto/connectivity/service/messaging/persistence/UsageBasedPriorityProviderFactory.java b/connectivity/service/src/main/java/org/eclipse/ditto/connectivity/service/messaging/persistence/UsageBasedPriorityProviderFactory.java index b3d45cb84a..7e55b81959 100644 --- a/connectivity/service/src/main/java/org/eclipse/ditto/connectivity/service/messaging/persistence/UsageBasedPriorityProviderFactory.java +++ b/connectivity/service/src/main/java/org/eclipse/ditto/connectivity/service/messaging/persistence/UsageBasedPriorityProviderFactory.java @@ -23,6 +23,7 @@ public class UsageBasedPriorityProviderFactory implements ConnectionPriorityProv /** * @param actorSystem the actor system in which to load the extension. + * @param config the config the extension is configured. */ protected UsageBasedPriorityProviderFactory(final ActorSystem actorSystem, final Config config) { } diff --git a/connectivity/service/src/main/java/org/eclipse/ditto/connectivity/service/messaging/validation/NoOpConnectivityCommandInterceptorProvider.java b/connectivity/service/src/main/java/org/eclipse/ditto/connectivity/service/messaging/validation/NoOpConnectivityCommandInterceptorProvider.java index dd7f847ea8..44b80ec7b7 100644 --- a/connectivity/service/src/main/java/org/eclipse/ditto/connectivity/service/messaging/validation/NoOpConnectivityCommandInterceptorProvider.java +++ b/connectivity/service/src/main/java/org/eclipse/ditto/connectivity/service/messaging/validation/NoOpConnectivityCommandInterceptorProvider.java @@ -26,6 +26,7 @@ public class NoOpConnectivityCommandInterceptorProvider implements CustomConnect /** * @param actorSystem the actor system in which to load the extension. + * @param config the config the extension is configured. */ protected NoOpConnectivityCommandInterceptorProvider(final ActorSystem actorSystem, final Config config) { } diff --git a/connectivity/service/src/test/java/org/eclipse/ditto/connectivity/service/messaging/ExceptionClientActorPropsFactory.java b/connectivity/service/src/test/java/org/eclipse/ditto/connectivity/service/messaging/ExceptionClientActorPropsFactory.java index 87a6e506e7..34052e4193 100644 --- a/connectivity/service/src/test/java/org/eclipse/ditto/connectivity/service/messaging/ExceptionClientActorPropsFactory.java +++ b/connectivity/service/src/test/java/org/eclipse/ditto/connectivity/service/messaging/ExceptionClientActorPropsFactory.java @@ -22,11 +22,14 @@ import akka.actor.ActorSystem; import akka.actor.Props; -public class ExceptionClientActorPropsFactory implements ClientActorPropsFactory{ +@SuppressWarnings("unused") +public class ExceptionClientActorPropsFactory implements ClientActorPropsFactory { /** * @param actorSystem the actor system in which to load the extension. + * @param config the config the extension is configured. */ + @SuppressWarnings("unused") protected ExceptionClientActorPropsFactory(final ActorSystem actorSystem, final Config config) { } diff --git a/connectivity/service/src/test/java/org/eclipse/ditto/connectivity/service/messaging/ExceptionalCommandValidator.java b/connectivity/service/src/test/java/org/eclipse/ditto/connectivity/service/messaging/ExceptionalCommandValidator.java index 25e893be02..6f54e9b5ce 100644 --- a/connectivity/service/src/test/java/org/eclipse/ditto/connectivity/service/messaging/ExceptionalCommandValidator.java +++ b/connectivity/service/src/test/java/org/eclipse/ditto/connectivity/service/messaging/ExceptionalCommandValidator.java @@ -28,6 +28,7 @@ public class ExceptionalCommandValidator implements CustomConnectivityCommandInt /** * @param actorSystem the actor system in which to load the extension. + * @param config the config the extension is configured. */ protected ExceptionalCommandValidator(final ActorSystem actorSystem, final Config config) { } diff --git a/connectivity/service/src/test/java/org/eclipse/ditto/connectivity/service/messaging/FaultyClientActorPropsFactory.java b/connectivity/service/src/test/java/org/eclipse/ditto/connectivity/service/messaging/FaultyClientActorPropsFactory.java index d677c14c89..9b13fb1f96 100644 --- a/connectivity/service/src/test/java/org/eclipse/ditto/connectivity/service/messaging/FaultyClientActorPropsFactory.java +++ b/connectivity/service/src/test/java/org/eclipse/ditto/connectivity/service/messaging/FaultyClientActorPropsFactory.java @@ -21,6 +21,7 @@ import akka.actor.ActorSystem; import akka.actor.Props; +@SuppressWarnings("unused") public final class FaultyClientActorPropsFactory implements ClientActorPropsFactory { private final boolean allowFirstCreateCommand; @@ -28,8 +29,10 @@ public final class FaultyClientActorPropsFactory implements ClientActorPropsFact /** * @param actorSystem the actor system in which to load the extension. + * @param config the config the extension is configured. */ - protected FaultyClientActorPropsFactory(final ActorSystem actorSystem, final Config config) { + @SuppressWarnings("unused") + private FaultyClientActorPropsFactory(final ActorSystem actorSystem, final Config config) { allowFirstCreateCommand = actorSystem.settings().config().getBoolean("allowFirstCreateCommand"); allowCloseCommands = actorSystem.settings().config().getBoolean("allowCloseCommands"); } diff --git a/connectivity/service/src/test/java/org/eclipse/ditto/connectivity/service/messaging/MockClientActorPropsFactory.java b/connectivity/service/src/test/java/org/eclipse/ditto/connectivity/service/messaging/MockClientActorPropsFactory.java index 1ce8cb50da..0bbcc55ba8 100644 --- a/connectivity/service/src/test/java/org/eclipse/ditto/connectivity/service/messaging/MockClientActorPropsFactory.java +++ b/connectivity/service/src/test/java/org/eclipse/ditto/connectivity/service/messaging/MockClientActorPropsFactory.java @@ -48,10 +48,12 @@ import akka.cluster.pubsub.DistributedPubSubMediator; import akka.event.DiagnosticLoggingAdapter; +@SuppressWarnings("unused") public final class MockClientActorPropsFactory implements ClientActorPropsFactory { /** * @param actorSystem the actor system in which to load the extension. + * @param config the config the extension is configured. */ public MockClientActorPropsFactory(final ActorSystem actorSystem, final Config config) { } diff --git a/connectivity/service/src/test/java/org/eclipse/ditto/connectivity/service/messaging/SearchForwardingClientActorPropsFactory.java b/connectivity/service/src/test/java/org/eclipse/ditto/connectivity/service/messaging/SearchForwardingClientActorPropsFactory.java index 44fce7e271..c02cd6f463 100644 --- a/connectivity/service/src/test/java/org/eclipse/ditto/connectivity/service/messaging/SearchForwardingClientActorPropsFactory.java +++ b/connectivity/service/src/test/java/org/eclipse/ditto/connectivity/service/messaging/SearchForwardingClientActorPropsFactory.java @@ -32,11 +32,14 @@ import akka.event.DiagnosticLoggingAdapter; import akka.japi.pf.ReceiveBuilder; +@SuppressWarnings("unused") public final class SearchForwardingClientActorPropsFactory implements ClientActorPropsFactory { /** * @param actorSystem the actor system in which to load the extension. + * @param config the config the extension is configured. */ + @SuppressWarnings("unused") public SearchForwardingClientActorPropsFactory(final ActorSystem actorSystem, final Config config) { } diff --git a/edge/service/src/main/java/org/eclipse/ditto/edge/service/dispatching/EdgeCommandForwarderExtension.java b/edge/service/src/main/java/org/eclipse/ditto/edge/service/dispatching/EdgeCommandForwarderExtension.java index aac1d81d61..5c76555abd 100644 --- a/edge/service/src/main/java/org/eclipse/ditto/edge/service/dispatching/EdgeCommandForwarderExtension.java +++ b/edge/service/src/main/java/org/eclipse/ditto/edge/service/dispatching/EdgeCommandForwarderExtension.java @@ -30,12 +30,12 @@ public interface EdgeCommandForwarderExtension extends DittoExtensionPoint { /** - * Loads the implementation of {@code RootChildActorStarter} which is configured for the + * Loads the implementation of {@code EdgeCommandForwarderExtension} which is configured for the * {@code ActorSystem}. * - * @param actorSystem the actorSystem in which the {@code RootChildActorStarter} should be loaded. + * @param actorSystem the actorSystem in which the {@code EdgeCommandForwarderExtension} should be loaded. * @param config the configuration for this extension. - * @return the {@code RootChildActorStarter} implementation. + * @return the {@code EdgeCommandForwarderExtension} implementation. * @throws NullPointerException if {@code actorSystem} is {@code null}. */ static EdgeCommandForwarderExtension get(final ActorSystem actorSystem, final Config config) { diff --git a/edge/service/src/main/java/org/eclipse/ditto/edge/service/dispatching/NoOpEdgeCommandForwarderExtension.java b/edge/service/src/main/java/org/eclipse/ditto/edge/service/dispatching/NoOpEdgeCommandForwarderExtension.java index ce7c793158..593c759f4b 100644 --- a/edge/service/src/main/java/org/eclipse/ditto/edge/service/dispatching/NoOpEdgeCommandForwarderExtension.java +++ b/edge/service/src/main/java/org/eclipse/ditto/edge/service/dispatching/NoOpEdgeCommandForwarderExtension.java @@ -31,7 +31,9 @@ public final class NoOpEdgeCommandForwarderExtension implements EdgeCommandForwa * Constructs a new instance of NoOpEdgeCommandForwarderExtension. * * @param actorSystem the actor system in which to load the extension. + * @param config the config the extension is configured. */ + @SuppressWarnings("unused") public NoOpEdgeCommandForwarderExtension(final ActorSystem actorSystem, final Config config) { // no-op } diff --git a/edge/service/src/main/java/org/eclipse/ditto/edge/service/dispatching/signaltransformer/DefaultNamespaceAppender.java b/edge/service/src/main/java/org/eclipse/ditto/edge/service/dispatching/signaltransformer/DefaultNamespaceAppender.java index 4f0a534a29..b336e78b34 100644 --- a/edge/service/src/main/java/org/eclipse/ditto/edge/service/dispatching/signaltransformer/DefaultNamespaceAppender.java +++ b/edge/service/src/main/java/org/eclipse/ditto/edge/service/dispatching/signaltransformer/DefaultNamespaceAppender.java @@ -50,7 +50,9 @@ public final class DefaultNamespaceAppender implements SignalTransformer { * Constructs a new instance of DefaultNamespaceAppender extension. * * @param actorSystem the actor system in which to load the extension. + * @param config the config the extension is configured. */ + @SuppressWarnings("unused") public DefaultNamespaceAppender(final ActorSystem actorSystem, final Config config) { defaultNamespace = config.hasPath(DEFAULT_NAMESPACE_CONFIG_KEY) ? config.getString(DEFAULT_NAMESPACE_CONFIG_KEY) : diff --git a/edge/service/src/main/java/org/eclipse/ditto/edge/service/dispatching/signaltransformer/OriginatorSetterSignalTransformer.java b/edge/service/src/main/java/org/eclipse/ditto/edge/service/dispatching/signaltransformer/OriginatorSetterSignalTransformer.java index 5bdb7ab47e..9d04cfc14f 100644 --- a/edge/service/src/main/java/org/eclipse/ditto/edge/service/dispatching/signaltransformer/OriginatorSetterSignalTransformer.java +++ b/edge/service/src/main/java/org/eclipse/ditto/edge/service/dispatching/signaltransformer/OriginatorSetterSignalTransformer.java @@ -39,6 +39,7 @@ public final class OriginatorSetterSignalTransformer implements SignalTransforme * Constructs a new instance of HeaderSetterPreEnforcer extension. * * @param actorSystem the actor system in which to load the extension. + * @param config the configuration for this extension. */ @SuppressWarnings("unused") public OriginatorSetterSignalTransformer(final ActorSystem actorSystem, final Config config) { diff --git a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/LoggingHttpBindFlowProvider.java b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/LoggingHttpBindFlowProvider.java index 1561217927..523a40169a 100644 --- a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/LoggingHttpBindFlowProvider.java +++ b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/LoggingHttpBindFlowProvider.java @@ -34,7 +34,9 @@ public final class LoggingHttpBindFlowProvider implements HttpBindFlowProvider { /** * @param actorSystem the actor system in which to load the extension. + * @param config the config the extension is configured. */ + @SuppressWarnings("unused") public LoggingHttpBindFlowProvider(final ActorSystem actorSystem, final Config config) { this.actorSystem = actorSystem; } diff --git a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/sse/NoOpSseConnectionSupervisor.java b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/sse/NoOpSseConnectionSupervisor.java index 3611080fe5..23e02d6ed6 100644 --- a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/sse/NoOpSseConnectionSupervisor.java +++ b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/sse/NoOpSseConnectionSupervisor.java @@ -26,7 +26,9 @@ public final class NoOpSseConnectionSupervisor implements SseConnectionSuperviso /** * @param actorSystem the actor system in which to load the extension. + * @param config the config the extension is configured. */ + @SuppressWarnings("unused") public NoOpSseConnectionSupervisor(final ActorSystem actorSystem, final Config config) { //No-Op because extensions need a constructor accepting an actorSystem } diff --git a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/sse/NoOpSseEventSniffer.java b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/sse/NoOpSseEventSniffer.java index 108dfe6a82..d626f3d387 100644 --- a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/sse/NoOpSseEventSniffer.java +++ b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/sse/NoOpSseEventSniffer.java @@ -25,6 +25,7 @@ */ public final class NoOpSseEventSniffer implements SseEventSniffer { + @SuppressWarnings("unused") public NoOpSseEventSniffer(final ActorSystem actorSystem, final Config config) { //No-Op because extensions need a constructor accepting an actorSystem } diff --git a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/sse/SseConnectionSupervisor.java b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/sse/SseConnectionSupervisor.java index 06d5bbe60c..ff203b126d 100644 --- a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/sse/SseConnectionSupervisor.java +++ b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/sse/SseConnectionSupervisor.java @@ -32,6 +32,7 @@ public interface SseConnectionSupervisor extends DittoExtensionPoint, StreamSupe * {@code ActorSystem}. * * @param actorSystem the actorSystem in which the {@code SseConnectionSupervisor} should be loaded. + * @param config the config the extension is configured. * @return the {@code SseConnectionSupervisor} implementation. * @throws NullPointerException if {@code actorSystem} is {@code null}. * @since 3.0.0 diff --git a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/sse/SseEventSniffer.java b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/sse/SseEventSniffer.java index 71f1f7c6f3..76527d3b16 100644 --- a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/sse/SseEventSniffer.java +++ b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/sse/SseEventSniffer.java @@ -43,6 +43,7 @@ public interface SseEventSniffer extends DittoExtensionPoint { * {@code ActorSystem}. * * @param actorSystem the actorSystem in which the {@code SseEventSniffer} should be loaded. + * @param config the config the extension is configured. * @return the {@code SseEventSniffer} implementation. * @throws NullPointerException if {@code actorSystem} is {@code null}. * @since 3.0.0 diff --git a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/websocket/NoOpWebSocketConfigProvider.java b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/websocket/NoOpWebSocketConfigProvider.java index 488e924109..c188063613 100644 --- a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/websocket/NoOpWebSocketConfigProvider.java +++ b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/websocket/NoOpWebSocketConfigProvider.java @@ -26,6 +26,7 @@ public final class NoOpWebSocketConfigProvider implements WebSocketConfigProvide /** * @param actorSystem the actor system in which to load the extension. + * @param config the config the extension is configured. */ @SuppressWarnings("unused") public NoOpWebSocketConfigProvider(final ActorSystem actorSystem, final Config config) { diff --git a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/websocket/NoOpWebSocketSupervisor.java b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/websocket/NoOpWebSocketSupervisor.java index 6ac00849d5..3d6dc2d39a 100644 --- a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/websocket/NoOpWebSocketSupervisor.java +++ b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/websocket/NoOpWebSocketSupervisor.java @@ -26,7 +26,9 @@ public final class NoOpWebSocketSupervisor implements WebSocketSupervisor { /** * @param actorSystem the actor system in which to load the extension. + * @param config the config the extension is configured. */ + @SuppressWarnings("unused") public NoOpWebSocketSupervisor(final ActorSystem actorSystem, final Config config) { //No-Op because extensions need a constructor accepting an actorSystem } diff --git a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/websocket/WebSocketSupervisor.java b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/websocket/WebSocketSupervisor.java index ed46bf76f8..bce531026b 100644 --- a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/websocket/WebSocketSupervisor.java +++ b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/routes/websocket/WebSocketSupervisor.java @@ -32,6 +32,7 @@ public interface WebSocketSupervisor extends DittoExtensionPoint, StreamSupervis * {@code ActorSystem}. * * @param actorSystem the actorSystem in which the {@code WebSocketSupervisor} should be loaded. + * @param config the config the extension is configured. * @return the {@code WebSocketSupervisor} implementation. * @throws NullPointerException if {@code actorSystem} is {@code null}. * @since 3.0.0 diff --git a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/utils/DefaultGatewaySignalEnrichmentProvider.java b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/utils/DefaultGatewaySignalEnrichmentProvider.java index cbb135473e..42bd142681 100644 --- a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/utils/DefaultGatewaySignalEnrichmentProvider.java +++ b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/endpoints/utils/DefaultGatewaySignalEnrichmentProvider.java @@ -33,7 +33,7 @@ */ public final class DefaultGatewaySignalEnrichmentProvider implements GatewaySignalEnrichmentProvider { - private static final String CONCIERGE_FORWARDER = "/user/gatewayRoot/" + EdgeCommandForwarderActor.ACTOR_NAME; + private static final String COMMAND_FORWARDER = "/user/gatewayRoot/" + EdgeCommandForwarderActor.ACTOR_NAME; private static final String CACHE_LOADER_DISPATCHER = "signal-enrichment-cache-dispatcher"; private final SignalEnrichmentFacade facade; @@ -42,9 +42,10 @@ public final class DefaultGatewaySignalEnrichmentProvider implements GatewaySign * Instantiate this provider. Called by reflection. * * @param actorSystem The actor system for which this provider is instantiated. + * @param config the config the extension is configured. */ public DefaultGatewaySignalEnrichmentProvider(final ActorSystem actorSystem, final Config config) { - final var commandHandler = actorSystem.actorSelection(CONCIERGE_FORWARDER); + final var commandHandler = actorSystem.actorSelection(COMMAND_FORWARDER); final var providerConfig = DefaultSignalEnrichmentProviderConfig.of(config); final var delegate = ByRoundTripSignalEnrichmentFacade.of(commandHandler, providerConfig.getAskTimeout()); if (providerConfig.isCachingEnabled()) { diff --git a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/security/authentication/jwt/DittoJwtAuthorizationSubjectsProvider.java b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/security/authentication/jwt/DittoJwtAuthorizationSubjectsProvider.java index 61cde58c62..cd26f974ca 100644 --- a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/security/authentication/jwt/DittoJwtAuthorizationSubjectsProvider.java +++ b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/security/authentication/jwt/DittoJwtAuthorizationSubjectsProvider.java @@ -49,7 +49,6 @@ public DittoJwtAuthorizationSubjectsProvider(final ActorSystem actorSystem, fina } private DittoJwtAuthorizationSubjectsProvider(final JwtSubjectIssuersConfig jwtSubjectIssuersConfig) { - this.jwtSubjectIssuersConfig = checkNotNull(jwtSubjectIssuersConfig); } diff --git a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/security/authentication/jwt/JwtAuthorizationSubjectsProvider.java b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/security/authentication/jwt/JwtAuthorizationSubjectsProvider.java index df6fc7c8be..faff1cc3c7 100644 --- a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/security/authentication/jwt/JwtAuthorizationSubjectsProvider.java +++ b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/security/authentication/jwt/JwtAuthorizationSubjectsProvider.java @@ -66,7 +66,6 @@ private ExtensionId(final ExtensionIdConfig ex } static ExtensionIdConfig computeConfig(final Config config) { - return ExtensionIdConfig.of(JwtAuthorizationSubjectsProvider.class, config, CONFIG_KEY); } diff --git a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/starter/GatewayRootActor.java b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/starter/GatewayRootActor.java index 9eadca4fcf..0539acf733 100755 --- a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/starter/GatewayRootActor.java +++ b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/starter/GatewayRootActor.java @@ -161,7 +161,6 @@ private GatewayRootActor(final GatewayConfig gatewayConfig, final ActorRef pubSu healthCheckActor, pubSubMediator, healthCheckConfig, jwtAuthenticationFactory, devopsAuthenticationDirectiveFactory, protocolAdapterProvider, headerTranslator); - httpBinding = Http.get(actorSystem) .newServerAt(hostname, httpConfig.getPort()) .bindFlow(HttpBindFlowProvider.get(actorSystem, dittoExtensionConfig).getFlow(rootRoute)) diff --git a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/streaming/NoOpAuthorizationEnforcer.java b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/streaming/NoOpAuthorizationEnforcer.java index b5b2aaf2a4..d7c5578d03 100644 --- a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/streaming/NoOpAuthorizationEnforcer.java +++ b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/streaming/NoOpAuthorizationEnforcer.java @@ -29,7 +29,9 @@ public final class NoOpAuthorizationEnforcer implements StreamingAuthorizationEn /** * @param actorSystem the actor system in which to load the extension. + *@param config the configuration for this extension. */ + @SuppressWarnings("unused") public NoOpAuthorizationEnforcer(final ActorSystem actorSystem, final Config config) { //No-Op because extensions need a constructor accepting an actorSystem } diff --git a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/streaming/StreamingAuthorizationEnforcer.java b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/streaming/StreamingAuthorizationEnforcer.java index a17ee9ef99..d17dcabbdf 100644 --- a/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/streaming/StreamingAuthorizationEnforcer.java +++ b/gateway/service/src/main/java/org/eclipse/ditto/gateway/service/streaming/StreamingAuthorizationEnforcer.java @@ -43,11 +43,12 @@ public interface StreamingAuthorizationEnforcer extends DittoExtensionPoint { CompletionStage checkAuthorization(RequestContext requestContext, DittoHeaders dittoHeaders); /** - * Loads the implementation of {@code WebSocketAuthorizationEnforcer} which is configured for the + * Loads the implementation of {@code StreamingAuthorizationEnforcer} which is configured for the * {@code ActorSystem}. * - * @param actorSystem the actorSystem in which the {@code WebSocketAuthorizationEnforcer} should be loaded. - * @return the {@code WebSocketAuthorizationEnforcer} implementation. + * @param actorSystem the actorSystem in which the {@code StreamingAuthorizationEnforcer} should be loaded. + * @param config the configuration for this extension. + * @return the {@code StreamingAuthorizationEnforcer} implementation. * @throws NullPointerException if {@code actorSystem} is {@code null}. * @since 3.0.0 */ diff --git a/internal/utils/extension/src/main/java/org/eclipse/ditto/internal/utils/extension/DittoExtensionPoint.java b/internal/utils/extension/src/main/java/org/eclipse/ditto/internal/utils/extension/DittoExtensionPoint.java index 82e64b9dc2..dd4357d205 100644 --- a/internal/utils/extension/src/main/java/org/eclipse/ditto/internal/utils/extension/DittoExtensionPoint.java +++ b/internal/utils/extension/src/main/java/org/eclipse/ditto/internal/utils/extension/DittoExtensionPoint.java @@ -110,7 +110,8 @@ public record ExtensionIdConfig(Class parentClass, * @param configKey the configuration key on root level of the given config. * @param The type of the extension that should be initialized. * @return the extension id config. - * @throws com.typesafe.config.ConfigException.WrongType in case neither an object nor a string is configured at the config key of config. + * @throws com.typesafe.config.ConfigException.WrongType in case neither an object nor a string is + * configured at the config key of config. */ public static ExtensionIdConfig of( final Class parentClass, @@ -127,6 +128,7 @@ public static ExtensionIdConfig of( @SuppressWarnings("unchecked") public static ExtensionIdConfig of(final Class parentClass, final ConfigValue configValue) { + final var valueType = configValue.valueType(); final Object unwrappedValue = configValue.unwrapped(); if (valueType == ConfigValueType.OBJECT) { @@ -148,6 +150,7 @@ private static ExtensionIdConfig ofStringConfig( private static ExtensionIdConfig ofObjectConfig( final Class parentClass, final Config config) { + @Nullable final String extensionClass; final Config extensionConfig; if (config.hasPath(EXTENSION_CLASS)) { diff --git a/policies/enforcement/src/main/java/org/eclipse/ditto/policies/enforcement/pre/BlockedNamespacePreEnforcer.java b/policies/enforcement/src/main/java/org/eclipse/ditto/policies/enforcement/pre/BlockedNamespacePreEnforcer.java index 6aaab1bf1c..e428fc2963 100644 --- a/policies/enforcement/src/main/java/org/eclipse/ditto/policies/enforcement/pre/BlockedNamespacePreEnforcer.java +++ b/policies/enforcement/src/main/java/org/eclipse/ditto/policies/enforcement/pre/BlockedNamespacePreEnforcer.java @@ -33,6 +33,7 @@ public final class BlockedNamespacePreEnforcer implements PreEnforcer { * Constructs a new instance of BlockedNamespacePreEnforcer extension. * * @param actorSystem the actor system in which to load the extension. + * @param config the configuration for this extension. */ @SuppressWarnings("unused") public BlockedNamespacePreEnforcer(final ActorSystem actorSystem, final Config config) { diff --git a/policies/enforcement/src/main/java/org/eclipse/ditto/policies/enforcement/pre/CommandWithOptionalEntityPreEnforcer.java b/policies/enforcement/src/main/java/org/eclipse/ditto/policies/enforcement/pre/CommandWithOptionalEntityPreEnforcer.java index 6e23325374..8d5c2f6da5 100644 --- a/policies/enforcement/src/main/java/org/eclipse/ditto/policies/enforcement/pre/CommandWithOptionalEntityPreEnforcer.java +++ b/policies/enforcement/src/main/java/org/eclipse/ditto/policies/enforcement/pre/CommandWithOptionalEntityPreEnforcer.java @@ -39,6 +39,7 @@ public final class CommandWithOptionalEntityPreEnforcer implements PreEnforcer { * Constructs a new instance of CommandWithOptionalEntityPreEnforcer extension. * * @param actorSystem the actor system in which to load the extension. + * @param config the configuration for this extension. */ @SuppressWarnings("unused") public CommandWithOptionalEntityPreEnforcer(final ActorSystem actorSystem, final Config config) { diff --git a/policies/enforcement/src/main/java/org/eclipse/ditto/policies/enforcement/pre/CreationRestrictionPreEnforcer.java b/policies/enforcement/src/main/java/org/eclipse/ditto/policies/enforcement/pre/CreationRestrictionPreEnforcer.java index ad67c9dbd1..67276ee1dd 100644 --- a/policies/enforcement/src/main/java/org/eclipse/ditto/policies/enforcement/pre/CreationRestrictionPreEnforcer.java +++ b/policies/enforcement/src/main/java/org/eclipse/ditto/policies/enforcement/pre/CreationRestrictionPreEnforcer.java @@ -51,6 +51,7 @@ public final class CreationRestrictionPreEnforcer implements PreEnforcer { * Constructs a new instance of CreationRestrictionPreEnforcer extension. * * @param actorSystem the actor system in which to load the extension. + * @param config the configuration for this extension. */ @SuppressWarnings("unused") public CreationRestrictionPreEnforcer(final ActorSystem actorSystem, final Config config) { diff --git a/policies/enforcement/src/main/java/org/eclipse/ditto/policies/enforcement/pre/PreEnforcerProvider.java b/policies/enforcement/src/main/java/org/eclipse/ditto/policies/enforcement/pre/PreEnforcerProvider.java index bb219af043..401fe6bd60 100644 --- a/policies/enforcement/src/main/java/org/eclipse/ditto/policies/enforcement/pre/PreEnforcerProvider.java +++ b/policies/enforcement/src/main/java/org/eclipse/ditto/policies/enforcement/pre/PreEnforcerProvider.java @@ -61,7 +61,6 @@ private PreEnforcerProvider(final ActorSystem actorSystem, final Config config) .toList(); } - /** * Applies the pre-enforcement to the signal. * @@ -86,6 +85,7 @@ public CompletionStage> apply(final Signal signal) { * {@code ActorSystem}. * * @param actorSystem the actorSystem in which the {@code PreEnforcerProvider} should be loaded. + * @param config the configuration for this extension. * @return the {@code PreEnforcerProvider} implementation. * @throws NullPointerException if {@code actorSystem} is {@code null}. */ diff --git a/policies/service/src/main/java/org/eclipse/ditto/policies/service/signaltransformation/placeholdersubstitution/PoliciesPlaceholderSubstitution.java b/policies/service/src/main/java/org/eclipse/ditto/policies/service/signaltransformation/placeholdersubstitution/PoliciesPlaceholderSubstitution.java index fa48783a9c..a168bb3766 100644 --- a/policies/service/src/main/java/org/eclipse/ditto/policies/service/signaltransformation/placeholdersubstitution/PoliciesPlaceholderSubstitution.java +++ b/policies/service/src/main/java/org/eclipse/ditto/policies/service/signaltransformation/placeholdersubstitution/PoliciesPlaceholderSubstitution.java @@ -32,6 +32,7 @@ public class PoliciesPlaceholderSubstitution extends AbstractPlaceholderSubstitu * Constructs a new instance of PoliciesPlaceholderSubstitutionPreEnforcer extension. * * @param actorSystem the actor system in which to load the extension. + * @param config the configuration for this extension. */ @SuppressWarnings("unused") public PoliciesPlaceholderSubstitution(final ActorSystem actorSystem, final Config config) { diff --git a/things/service/src/main/java/org/eclipse/ditto/things/service/signaltransformation/placeholdersubstitution/ThingsPlaceholderSubstitution.java b/things/service/src/main/java/org/eclipse/ditto/things/service/signaltransformation/placeholdersubstitution/ThingsPlaceholderSubstitution.java index 861c902f34..451316bd49 100644 --- a/things/service/src/main/java/org/eclipse/ditto/things/service/signaltransformation/placeholdersubstitution/ThingsPlaceholderSubstitution.java +++ b/things/service/src/main/java/org/eclipse/ditto/things/service/signaltransformation/placeholdersubstitution/ThingsPlaceholderSubstitution.java @@ -32,6 +32,7 @@ public class ThingsPlaceholderSubstitution extends AbstractPlaceholderSubstituti * Constructs a new instance of ThingsPlaceholderSubstitutionPreEnforcer extension. * * @param actorSystem the actor system in which to load the extension. + * @param config the configuration for this extension. */ @SuppressWarnings("unused") public ThingsPlaceholderSubstitution(final ActorSystem actorSystem, final Config config) { diff --git a/thingsearch/service/src/main/java/org/eclipse/ditto/thingsearch/service/persistence/query/validation/DefaultQueryCriteriaValidator.java b/thingsearch/service/src/main/java/org/eclipse/ditto/thingsearch/service/persistence/query/validation/DefaultQueryCriteriaValidator.java index 4a58ca27a3..603aadcdd6 100644 --- a/thingsearch/service/src/main/java/org/eclipse/ditto/thingsearch/service/persistence/query/validation/DefaultQueryCriteriaValidator.java +++ b/thingsearch/service/src/main/java/org/eclipse/ditto/thingsearch/service/persistence/query/validation/DefaultQueryCriteriaValidator.java @@ -30,7 +30,10 @@ public final class DefaultQueryCriteriaValidator implements QueryCriteriaValidat /** * Instantiate this provider. Called by reflection. + * @param actorSystem the actor system in which to load the extension. + * @param config the configuration for this extension. */ + @SuppressWarnings("unused") public DefaultQueryCriteriaValidator(final ActorSystem actorSystem, final Config config) { // Nothing to initialize. } diff --git a/thingsearch/service/src/main/java/org/eclipse/ditto/thingsearch/service/persistence/write/streaming/DefaultSearchUpdateMapper.java b/thingsearch/service/src/main/java/org/eclipse/ditto/thingsearch/service/persistence/write/streaming/DefaultSearchUpdateMapper.java index 45cdf1ea36..f3c3d3ae43 100644 --- a/thingsearch/service/src/main/java/org/eclipse/ditto/thingsearch/service/persistence/write/streaming/DefaultSearchUpdateMapper.java +++ b/thingsearch/service/src/main/java/org/eclipse/ditto/thingsearch/service/persistence/write/streaming/DefaultSearchUpdateMapper.java @@ -32,6 +32,8 @@ public final class DefaultSearchUpdateMapper extends SearchUpdateMapper { /** * Instantiate this provider. Called by reflection. + * @param actorSystem the actor system in which to load the extension. + * @param config the configuration for this extension. */ @SuppressWarnings("unused") private DefaultSearchUpdateMapper(final ActorSystem actorSystem, final Config config) { diff --git a/thingsearch/service/src/main/java/org/eclipse/ditto/thingsearch/service/persistence/write/streaming/DittoCachingSignalEnrichmentFacadeProvider.java b/thingsearch/service/src/main/java/org/eclipse/ditto/thingsearch/service/persistence/write/streaming/DittoCachingSignalEnrichmentFacadeProvider.java index 776f211934..d6ed3f8311 100644 --- a/thingsearch/service/src/main/java/org/eclipse/ditto/thingsearch/service/persistence/write/streaming/DittoCachingSignalEnrichmentFacadeProvider.java +++ b/thingsearch/service/src/main/java/org/eclipse/ditto/thingsearch/service/persistence/write/streaming/DittoCachingSignalEnrichmentFacadeProvider.java @@ -30,7 +30,10 @@ public final class DittoCachingSignalEnrichmentFacadeProvider implements Caching /** * Instantiate this provider. Called by reflection. + * @param actorSystem the actor system in which to load the extension. + * @param config the configuration for this extension. */ + @SuppressWarnings("unused") public DittoCachingSignalEnrichmentFacadeProvider(final ActorSystem actorSystem, final Config config) { // No-Op but required for extension initialisation } diff --git a/thingsearch/service/src/main/java/org/eclipse/ditto/thingsearch/service/persistence/write/streaming/SearchUpdateMapper.java b/thingsearch/service/src/main/java/org/eclipse/ditto/thingsearch/service/persistence/write/streaming/SearchUpdateMapper.java index 53c1aa9500..12a8d04e82 100644 --- a/thingsearch/service/src/main/java/org/eclipse/ditto/thingsearch/service/persistence/write/streaming/SearchUpdateMapper.java +++ b/thingsearch/service/src/main/java/org/eclipse/ditto/thingsearch/service/persistence/write/streaming/SearchUpdateMapper.java @@ -69,6 +69,7 @@ public abstract Source processWriteModel(AbstractWrite * Load a {@code SearchUpdateListener} dynamically according to the search configuration. * * @param actorSystem The actor system in which to load the listener. + * @param config the configuration for this extension. * @return The listener. */ public static SearchUpdateMapper get(final ActorSystem actorSystem, final Config config) { diff --git a/thingsearch/service/src/main/java/org/eclipse/ditto/thingsearch/service/updater/actors/SearchUpdateObserver.java b/thingsearch/service/src/main/java/org/eclipse/ditto/thingsearch/service/updater/actors/SearchUpdateObserver.java index 180a1b1b52..a7a4962f9c 100644 --- a/thingsearch/service/src/main/java/org/eclipse/ditto/thingsearch/service/updater/actors/SearchUpdateObserver.java +++ b/thingsearch/service/src/main/java/org/eclipse/ditto/thingsearch/service/updater/actors/SearchUpdateObserver.java @@ -48,6 +48,7 @@ public interface SearchUpdateObserver extends DittoExtensionPoint { * {@code ActorSystem}. * * @param actorSystem the actorSystem in which the {@code SearchUpdateObserver} should be loaded. + * @param config the configuration for this extension. * @return the {@code SearchUpdateObserver} implementation. * @throws NullPointerException if {@code actorSystem} is {@code null}. */