Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a payload mapper to convert directly between message command payload and external messages #777

Closed
yufei-cai opened this issue Aug 27, 2020 · 0 comments · Fixed by #794
Milestone

Comments

@yufei-cai
Copy link
Contributor

The payload mapper should behave similarly to the messages HTTP API in that it converts between the payload of message commands and the payload of messages over protocols such as AMQP, MQTT and Kafka. For incoming messages, the mapper may optimize the presentation of the payload for the Ditto protocol JSON format according to content type.

@thjaeckle thjaeckle added this to the 1.3.0 milestone Aug 28, 2020
Yannic92 pushed a commit to bosch-io/ditto that referenced this issue Sep 9, 2020
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Yannic92 pushed a commit to bosch-io/ditto that referenced this issue Sep 9, 2020
…cision of text vs. binary message payload.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Yannic92 pushed a commit to bosch-io/ditto that referenced this issue Sep 9, 2020
…guration.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Yannic92 pushed a commit to bosch-io/ditto that referenced this issue Sep 9, 2020
…ers of incoming messages.

- Add unit test for incoming mapping.
- Fix an inconsistent content-type checking in protocol adapter.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Yannic92 pushed a commit to bosch-io/ditto that referenced this issue Sep 9, 2020
…signal and content type.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Yannic92 pushed a commit to bosch-io/ditto that referenced this issue Sep 9, 2020
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Yannic92 pushed a commit to bosch-io/ditto that referenced this issue Sep 9, 2020
- Removed unsafe type parameter in .fromJson methods of message
  commands and responses.

- Set message payload and raw payload during deserialization
  whenever possible.

- Use the same deserialization for signals and adaptables.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Yannic92 pushed a commit to bosch-io/ditto that referenced this issue Sep 9, 2020
…ayload.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Yannic92 pushed a commit to bosch-io/ditto that referenced this issue Sep 9, 2020
…ge deserializer.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
DerSchwilk pushed a commit to bosch-io/ditto that referenced this issue Sep 10, 2020
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
DerSchwilk pushed a commit to bosch-io/ditto that referenced this issue Sep 10, 2020
…cision of text vs. binary message payload.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
DerSchwilk pushed a commit to bosch-io/ditto that referenced this issue Sep 10, 2020
…guration.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
DerSchwilk pushed a commit to bosch-io/ditto that referenced this issue Sep 10, 2020
…ers of incoming messages.

- Add unit test for incoming mapping.
- Fix an inconsistent content-type checking in protocol adapter.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
DerSchwilk pushed a commit to bosch-io/ditto that referenced this issue Sep 10, 2020
…signal and content type.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
DerSchwilk pushed a commit to bosch-io/ditto that referenced this issue Sep 10, 2020
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
DerSchwilk pushed a commit to bosch-io/ditto that referenced this issue Sep 10, 2020
- Removed unsafe type parameter in .fromJson methods of message
  commands and responses.

- Set message payload and raw payload during deserialization
  whenever possible.

- Use the same deserialization for signals and adaptables.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
DerSchwilk pushed a commit to bosch-io/ditto that referenced this issue Sep 10, 2020
…ayload.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
DerSchwilk pushed a commit to bosch-io/ditto that referenced this issue Sep 10, 2020
…ge deserializer.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
DerSchwilk pushed a commit to bosch-io/ditto that referenced this issue Sep 10, 2020
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
DerSchwilk pushed a commit to bosch-io/ditto that referenced this issue Sep 10, 2020
…cision of text vs. binary message payload.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
DerSchwilk pushed a commit to bosch-io/ditto that referenced this issue Sep 10, 2020
…guration.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
DerSchwilk pushed a commit to bosch-io/ditto that referenced this issue Sep 10, 2020
…ers of incoming messages.

- Add unit test for incoming mapping.
- Fix an inconsistent content-type checking in protocol adapter.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
DerSchwilk pushed a commit to bosch-io/ditto that referenced this issue Sep 10, 2020
…signal and content type.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
DerSchwilk pushed a commit to bosch-io/ditto that referenced this issue Sep 10, 2020
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
DerSchwilk pushed a commit to bosch-io/ditto that referenced this issue Sep 10, 2020
- Removed unsafe type parameter in .fromJson methods of message
  commands and responses.

- Set message payload and raw payload during deserialization
  whenever possible.

- Use the same deserialization for signals and adaptables.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
DerSchwilk pushed a commit to bosch-io/ditto that referenced this issue Sep 10, 2020
…ayload.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
DerSchwilk pushed a commit to bosch-io/ditto that referenced this issue Sep 10, 2020
…ge deserializer.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants