Skip to content

Conversation

@paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Sep 20, 2022

What this PR changes/adds

Moves all the metamodel classes and annotation, such as @Provides, @Inject etc. and the contents of tooling/module-domain of the EDC repo out of there and into this repository.

Why it does that

Many of the metamodel annotations and classes are used by EDC and by a (yet-to-implement) autodoc plugin, thus there must be a standalone artifact providing these classes.

Further notes

  • in the EDC repo there will be a corresponding PR, in which the code is removed and the import statements are updated. However, this should be merged first, and a release must be pushed to MavenCentral.

Linked Issue(s)

Contributes to eclipse-edc/Connector#1988

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contribution guidelines, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.

@paullatzelsperger paullatzelsperger changed the title Cleanup/move autodoc model here Cleanup: move autodoc model here Sep 20, 2022
@paullatzelsperger paullatzelsperger changed the title Cleanup: move autodoc model here Cleanup: move EDC runtime metamodel here Sep 20, 2022
@paullatzelsperger paullatzelsperger added the enhancement New feature or request label Sep 20, 2022
@paullatzelsperger paullatzelsperger changed the title Cleanup: move EDC runtime metamodel here Refactor: move EDC runtime metamodel here Sep 20, 2022
@paullatzelsperger paullatzelsperger changed the title Refactor: move EDC runtime metamodel here refactor: move edc runtime metamodel here Sep 21, 2022
@paullatzelsperger paullatzelsperger force-pushed the cleanup/move_autodoc_model_here branch from 3da132b to 01532dd Compare September 21, 2022 09:33
@paullatzelsperger paullatzelsperger merged commit bb122e3 into eclipse-edc:main Sep 22, 2022
@paullatzelsperger paullatzelsperger deleted the cleanup/move_autodoc_model_here branch September 22, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants