Skip to content

Conversation

@ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Apr 3, 2023

What this PR changes/adds

Use null safe code to get version from the catalog

Why it does that

Avoid NPE

Further notes

  • suppressed annoying "text-fixtures" warning on publication

Linked Issue(s)

Closes #126

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Test Results

38 tests  ±0   38 ✔️ ±0   27s ⏱️ ±0s
12 suites ±0     0 💤 ±0 
12 files   ±0     0 ±0 

Results for commit 5dd5a3d. ± Comparison against base commit c810021.

@ndr-brt ndr-brt merged commit 213d2a1 into main Apr 3, 2023
@ndr-brt ndr-brt deleted the 126-avoid-npe branch April 3, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NullPointerException thrown by edc-build if default dependencies are missing from the catalog

3 participants