Bug 535820: move Corba and IIOP to standalone module #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Kraus <tomas.kraus@oracle.com> Resolved problem with sun.misc dependencies. GF CORBA updated to 4.2.0.b003. Signed-off-by: Tomas Kraus <tomas.kraus@oracle.com> Build cleanup. Signed-off-by: Tomas Kraus <tomas.kraus@oracle.com> Additional build cleanup. Signed-off-by: Tomas Kraus <tomas.kraus@oracle.com> Removed JDK9 condition, updated build for remote P2 site. Signed-off-by: Tomas Kraus <tomas.kraus@oracle.com> GMBAL API updated to 3.2.0.b003 complete the CORBA separation Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com> preparation for jdk11 uptake Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com> temp Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com> add corba jar to the distribution zip Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com> remove unused property Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com> adopt recent changes Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com> need api in the file name Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com> switch to jdk11, wildfly 15.0.1; fix corba tests Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com> increase timeouts Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com> tmp - debug corba failures Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com> set different port for corba server Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com> clean up corba tests, update dbws builder tests for jdk11 Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com> update dbws tests for jdk11 Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com> fix dbwsbuilder tests for jdk11 Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com> fix sdo tests for jdk11 Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com> fix javadoc and test-osgi on jdk11 Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
|
@Tomas-Kraus @dazey3 @rfelcman this is now ready for final review. Most notable changes:
|
rfelcman
reviewed
Feb 25, 2019
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
rfelcman
reviewed
Feb 27, 2019
|
LGTM (just comment: In eclipselink.extension.corba.test java.policy.allpermissions file shoud be placed into resource instead of run directory. |
|
the policy file is in resources. It's being copied over to run before test execution, so tests find it in common location |
|
@lukasj After this commit, I started getting the following exception when I call [java] [INFO] Resolving dependencies of MavenProject: org.eclipse.persistence:org.eclipse.persistence.corba:3.0.0-SNAPSHOT @ C:\JPA\EL\master\trunk\eclipselink.runtime\foundation\org.eclipse.persistence.corba\pom.xml
[java] [INFO] {osgi.os=linux, osgi.ws=gtk, org.eclipse.update.install.features=true, osgi.arch=x86_64}
[java] [ERROR] Cannot resolve project dependencies:
[java] [ERROR] Software being installed: org.eclipse.persistence.corba 3.0.0.qualifier
[java] [ERROR] Missing requirement: org.eclipse.persistence.corba 3.0.0.qualifier requires 'java.package; javax.rmi 1.0.0' but it could not be found
[java] [ERROR]
[java] [ERROR] See http://wiki.eclipse.org/Tycho/Dependency_Resolution_Troubleshooting for help.
[java] [ERROR] Cannot resolve dependencies of MavenProject: org.eclipse.persistence:org.eclipse.persistence.corba:3.0.0-SNAPSHOT @ C:\JPA\EL\master\trunk\eclipselink.runtime\foundation\org.eclipse.persistence.corba\pom.xml: See log for details -> [Help 1]
[java] [ERROR]
[java] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[java] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[java] [ERROR]
[java] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[java] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MavenExecutionExceptionI assume that there is something I need to build to get this working |
|
@dazey3 are you sure your branch is at current master head? |
|
@lukasj At current master HEAD, I get the same exception. I rolled back to determine where the exception started and I found it started with this PR. Unfortunately, I haven't stayed as up to date as I probably should with master, so this one skipped past me until I just updated while working on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.