Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency to the java.desktop JPMS module #47

Closed
glassfishrobot opened this issue Feb 15, 2018 · 4 comments · Fixed by #195
Closed

Dependency to the java.desktop JPMS module #47

glassfishrobot opened this issue Feb 15, 2018 · 4 comments · Fixed by #195
Assignees
Labels
Component: API Affects the API and (by implication) the spec and all implementations improvement Jakarta EE 11 Priority: Major

Comments

@glassfishrobot
Copy link

Hi,

So it's probably something that cannot be fixed easily but I thought you should be made aware of it.

The ELResolver abstract class depends on java.beans.FeatureDescriptor (and implementations are using Introspector#getBeanInfo()) and unfortunately the java.beans package is part of the java.desktop module.

Thus, if you use javax.el in a modularized environment, you will need the java.desktop module which is very unfortunate.

In the long run, either java.beans should be extracted from the java.desktop module or we should try to remove the dependency to it.

@glassfishrobot
Copy link
Author

@arjantijms arjantijms self-assigned this Jul 28, 2019
@markt-asf markt-asf added Component: API Affects the API and (by implication) the spec and all implementations improvement Priority: Major Jakarta EE 10 labels Jan 24, 2020
@markt-asf
Copy link
Contributor

My research so far has not found any significant uses of FeatureDescriptor. Therefore, methods referencing FeatureDescriptor will be deprecated for removal without replacement in 5.0 with the intention of removing them in 6.0. Should a use case these emerge later, we always have the option to re-evaluate this plan any time before the 6.0 release which I am currently expecting to be aligned with Jakarta EE 11.

markt-asf added a commit to markt-asf/el-ri that referenced this issue Sep 6, 2021
Removal will need to wait until the next major release (6.0).
@markt-asf
Copy link
Contributor

Complete all we can for now. Remaining work needs to wait for Jakarta EE 11.

@markt-asf
Copy link
Contributor

Note that there will also need to be some internal work to the BeanELResolver to completely remove this dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: API Affects the API and (by implication) the spec and all implementations improvement Jakarta EE 11 Priority: Major
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants