PageSession stored directly to view scope #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@avpinchuk , @arjantijms , please review. |
|
@OndroMih, Looks good. I build GF and try to deploy and undeploy a simple |
|
But why not use simple raw |
You're right, why not. I've changed it :) |
Storing into a map in view scope preferred page session over view session. But in JSF there's no page session, view scope is equivalent, the old page scope should be the same as JSF view scope. Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
More efficient if the target class is known. Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
avpinchuk
approved these changes
Apr 22, 2023
OndroMih
force-pushed
the
ondromih-fix-gf-24383-page-session-preceedes-request-scope
branch
from
dada8ef
to
7904fd0
Compare
|
@avpinchuk , please approve again. I had to fix the author information in my commits and force push to fix the ECA issue. |
avpinchuk
approved these changes
Apr 22, 2023
arjantijms
approved these changes
Apr 23, 2023
|
Not working deploy war file in glassfish 7.0.3 ->GUI internal error: Archive Path is NULL |
|
This is fixed in GlassFish 7.0.4. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing into a map in view scope preferred page session over view session. But in JSF there's no page session, view scope is equivalent, the old page scope should be the same as JSF view scope.
This should fix eclipse-ee4j/glassfish#24383 and potentially some other issues in GlassFish, which were introduced by #82.