Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure the Concurrency TCK tests to produce log files in the "target" directory #24571

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Configure the Concurrency TCK tests to produce log files in the "target" directory #24571

merged 2 commits into from
Sep 7, 2023

Conversation

OndroMih
Copy link
Contributor

@OndroMih OndroMih commented Sep 3, 2023

No description provided.

@OndroMih
Ignore log files produced by the Concurrency TCK tests
14d7380 
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
@dmatej
Copy link
Contributor

dmatej commented Sep 3, 2023

It would be better if they would be ignored under the target directory instead. Can you take a look if there is some option we should set for that?

@OndroMih
Copy link
Contributor Author

OndroMih commented Sep 5, 2023

It would be better if they would be ignored under the target directory instead. Can you take a look if there is some option we should set for that?

I agree. I found a solution with workingDirectory for the surefire and failsafe plugins that I already used here: #24576.

@OndroMih
Create Concurrency TCK log files in the "target" directory
6678974 
To separate them from versioned files.
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
@OndroMih OndroMih changed the title Ignore log files produced by the Concurrency TCK tests Configure the Concurrency TCK tests to produce log files in the "target" directory Sep 6, 2023
@OndroMih
Copy link
Contributor Author

OndroMih commented Sep 6, 2023

I found even a simpler solution, @dmatej I think this is what you meant initially :)

@OndroMih
Copy link
Contributor Author

OndroMih commented Sep 6, 2023

Please squash the commits when merging

@arjantijms arjantijms merged commit a6622d3 into eclipse-ee4j:master Sep 7, 2023
2 checks passed
@dmatej dmatej added this to the 7.0.9 milestone Sep 7, 2023
@dmatej
Copy link
Contributor

dmatej commented Sep 7, 2023

I found even a simpler solution, @dmatej I think this is what you meant initially :)

Yeah, that was exactly that! I deleted those logs so many times but I was always lazy/distracted to resolve this issue, thanks! :-)

@OndroMih OndroMih deleted the ondromih-ignore-concurrency-tck-logs branch October 29, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjantijms arjantijms arjantijms approved these changes

@avpinchuk avpinchuk avpinchuk approved these changes

Assignees
No one assigned
Labels
build and test improvement
Projects
None yet
Milestone
7.0.9
Development

Successfully merging this pull request may close these issues.
4 participants
@OndroMih @dmatej @arjantijms @avpinchuk