Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java-module.java Allowed contents for Jakarta EE 9 #162

Open
starksm64 opened this issue Mar 10, 2020 · 1 comment
Open

java-module.java Allowed contents for Jakarta EE 9 #162

starksm64 opened this issue Mar 10, 2020 · 1 comment

Comments

@starksm64
Copy link
Member

@starksm64 starksm64 commented Mar 10, 2020

While looking at the jakarta.persistence:jakarta.persistence-api:3.0.0-RC1 API jar available from
https://repo1.maven.org/maven2/jakarta/persistence/jakarta.persistence-api/3.0.0-RC1/jakarta.persistence-api-3.0.0-RC1.jar

It was noticed that it contained a module-info.class that contains potentially unwanted dependencies:

module jakarta.persistence {

    requires java.logging;
    requires transitive java.instrument;
    requires transitive java.sql;

    exports jakarta.persistence;
    exports jakarta.persistence.criteria;
    exports jakarta.persistence.metamodel;
    exports jakarta.persistence.spi;

    uses jakarta.persistence.spi.PersistenceProvider;
}

An issue was raised in the jpa-api project to question this:
eclipse-ee4j/jpa-api#264

but the issue for the platform project is what guidelines do we need to document for the Jakarta EE 9 release?

@bshannon
Copy link
Contributor

@bshannon bshannon commented Mar 13, 2020

These additional types are part of the JPA API so they need to be declared in
the module-info.

I hate to go down the rat hole of fully defining guidelines for module-info for
this release, but it may be inevitable. I just think we have to allow that the
guidelines might change later in an incompatible way as we more to adding
module support to the specs.

@keilw keilw changed the title java-module.java Allowed contents for Jakarata EE 9 java-module.java Allowed contents for Jakarta EE 9 Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.