New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OsgiRegistry attempts to load classes from comment lines #3846

Open
jesse-gallagher opened this Issue Jun 4, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@jesse-gallagher
Copy link

jesse-gallagher commented Jun 4, 2018

while ((providerClassName = reader.readLine()) != null) {

I've run into a problem in my (admittedly bizarre) environment where I'm attempting to bind Jersey with Weld in an OSGi environment that's a bit too old to use the non-SE Weld container. Setting aside the ugliness of my project, I found that the OsgiLoader class attempts to load lines from factory files that start with "#", such as this one from the cdi2-se package:

https://github.com/eclipse-ee4j/jersey/blob/12a057315292a624ceb31b58bd04eec3cb19a819/inject/cdi2-se/src/main/resources/META-INF/services/org.glassfish.jersey.internal.inject.InjectionManagerFactory

@jansupol jansupol added the 2.28 label Jun 4, 2018

jesse-gallagher added a commit to jesse-gallagher/jersey that referenced this issue Jun 4, 2018

jansupol added a commit that referenced this issue Sep 18, 2018

Issue #3846: Skip comment lines in service files in OSGi (#3935)
Signed-off-by: Jan Supol <jan.supol@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment