Package renamed: javax -> jakarta #217
Conversation
Signed-off-by: Tomas Kraus <Tomas.Kraus@oracle.com>
api/pom.xml
Outdated
| @@ -90,7 +90,7 @@ | |||
| <non.final>false</non.final> | |||
| <skip.release.tests>false</skip.release.tests> | |||
| <spec.version>1.1</spec.version> | |||
| <jakarta.json.version>1.1.5</jakarta.json.version> | |||
| <jakarta.json.version>2.0-SNAPSHOT</jakarta.json.version> | |||
There was a problem hiding this comment.
Is this publicly available anywhere? Or are you building JSON-P API from source?
There was a problem hiding this comment.
@aguibert take a look at oss sonatype snapshot repo: https://oss.sonatype.org/service/local/repositories/snapshots/content/jakarta/json/jakarta.json-api/2.0-SNAPSHOT/
There was a problem hiding this comment.
I don't like dependencies on snapshots. Let's release beta of JSONP API with Jakarta changes before merging this PR.
There was a problem hiding this comment.
@m0mus are you saying we should release jsonp-2-rc1 this week and rc2 next week where the only difference is going to be updated parent pom? Is there a need to rush that much instead of having some time to review this and just "block" merging before required jsonp becomes available? Downstream projects can either wait or build what is required themselves to not be blocked...
There was a problem hiding this comment.
@lukasj New parent pom is released. We should release JSONP2 RC1 this week. There is no need to release RC2 next week.
There was a problem hiding this comment.
@Tomas-Kraus please check it. Something went wrong with the parent pom release yesterday.
There was a problem hiding this comment.
According to this jakartaee/messaging#253 (comment) version number has to be changed to 2.0.0-SNAPSHOT
There was a problem hiding this comment.
would you mind filing an issue(s) to the appropriate project?
There was a problem hiding this comment.
Nothing went wrong, I did release to staging. Script for central release was never implemented for parent pom project. I did it today.
[INFO] * Connected to Nexus at https://jakarta.oss.sonatype.org:443/, is version 2.14.15-01 and edition "Professional"
[INFO] RC-Releasing staging repository with IDs=[orgeclipseee4j-1001]
Waiting for operation to complete...
..
[INFO] Released
There was a problem hiding this comment.
jsonp 2.0.0-RC1 is in staging so version was updated.
api/src/main/java/module-info.java
Outdated
| exports jakarta.json.bind.annotation; | ||
| exports jakarta.json.bind.config; | ||
| exports jakarta.json.bind.serializer; | ||
| exports jakarta.json.bind.spi; | ||
|
|
||
| requires java.json; |
There was a problem hiding this comment.
Is the name for the JSON-P module still java.json? Or did it change to jakarta.json? We should remain consistent with whatever JSON-P (and the rest of the Jakarta EE platform does)
There was a problem hiding this comment.
It should be changed to jakarta.
There was a problem hiding this comment.
Already done with jsonp 2.0.0-RC1.
Signed-off-by: Tomas Kraus <Tomas.Kraus@oracle.com>
Tomas-Kraus
changed the title
Renamed
javaxpackage prefix tojakartain sources, documentation and spec.Dependencies update: