Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some extra Javax to Jakarta changes #448

Merged
merged 2 commits into from May 11, 2020
Merged

Some extra Javax to Jakarta changes #448

merged 2 commits into from May 11, 2020

Conversation

arjantijms
Copy link
Contributor

Updated some occurrences of javax to jakarta. Especially the mail/src/main/resources/META-INF/hk2-locator/default is important, as it prevents GlassFish from starting.

Signed-off-by: arjantijms arjan.tijms@gmail.com

@arjantijms
Some extra Javax to Jakarta changes
c53c97d 
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
@lukasj
Copy link
Contributor

lukasj commented May 8, 2020

don't you need also #446 fixed?

@arjantijms
Rename javax.* service files to jakarta.*
9448e99 
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
@arjantijms
Copy link
Contributor Author

@lukasj

Indeed, thx!

Archive now contains the service file in jakarta.*:

unzip -l mail/target/jakarta.mail.jar | grep META-INF
     2901  05-08-2020 12:09   META-INF/MANIFEST.MF
        0  05-08-2020 12:09   META-INF/
        0  05-08-2020 12:08   META-INF/services/
        0  05-08-2020 12:08   META-INF/hk2-locator/
        0  05-08-2020 12:09   META-INF/maven/
        0  05-08-2020 12:09   META-INF/maven/com.sun.mail/
        0  05-08-2020 12:09   META-INF/maven/com.sun.mail/jakarta.mail/
     2555  05-08-2020 12:08   META-INF/gfprobe-provider.xml
     1598  05-08-2020 12:08   META-INF/javamail.charset.map
      598  05-08-2020 12:08   META-INF/javamail.default.providers
       12  05-08-2020 12:08   META-INF/javamail.default.address.map
    35084  05-08-2020 12:08   META-INF/LICENSE.txt
      699  05-08-2020 12:08   META-INF/mailcap
      195  05-08-2020 12:08   META-INF/services/jakarta.mail.Provider
      339  05-08-2020 12:08   META-INF/hk2-locator/default
     5928  05-08-2020 01:28   META-INF/maven/com.sun.mail/jakarta.mail/pom.xml
       63  05-08-2020 12:09   META-INF/maven/com.sun.mail/jakarta.mail/pom.properties

kwsutter
kwsutter approved these changes May 8, 2020
View reviewed changes
Copy link

@kwsutter kwsutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; Thanks!

@arjantijms arjantijms mentioned this pull request May 8, 2020
Closed
11 tasks
lukasj
lukasj approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m0mus m0mus merged commit 4cc00ac into jakartaee:master May 11, 2020
@lukasj
Copy link
Contributor

lukasj commented May 12, 2020

@arjantijms RC5 is in staging. We will send it to central after some testing, so either let us know it's fine or wait a day. Thx

@arjantijms arjantijms mentioned this pull request May 12, 2020
Merged
@jGauravGupta jGauravGupta mentioned this pull request May 13, 2020
Closed
11 tasks
bvfalcon pushed a commit to bvfalcon/jakarta-mail that referenced this pull request Aug 8, 2022
@arjantijms
Some extra Javax to Jakarta changes (jakartaee#448)
9ac0c20 
* Some extra Javax to Jakarta changes


Signed-off-by: arjantijms <arjan.tijms@gmail.com>

* Rename javax.* service files to jakarta.*

Signed-off-by: arjantijms <arjan.tijms@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasj lukasj lukasj approved these changes

@kwsutter kwsutter kwsutter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arjantijms @lukasj @kwsutter @m0mus