Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint class qualifiers for @WebSocketEndpoint #53

Closed
glassfishrobot opened this issue Oct 26, 2012 · 9 comments
Closed

Endpoint class qualifiers for @WebSocketEndpoint #53

glassfishrobot opened this issue Oct 26, 2012 · 9 comments

Comments

@glassfishrobot
Copy link

Define whether the endpoint class needs to be public, or final ? Can it be abstract etc ? Also make sure it is conformant with other EE specs.

@glassfishrobot
Copy link
Author

@glassfishrobot Commented
Reported by jitu

@glassfishrobot
Copy link
Author

@glassfishrobot Commented
Was assigned to dannycoward

@glassfishrobot
Copy link
Author

@glassfishrobot Commented
dannycoward said:
See section 4.1 of the spec which refers additionally to 7.3.1.

Jitu: Let me know if you think anything is missing, I'm following standard practice with, for example, JAX-RS.

@glassfishrobot
Copy link
Author

@glassfishrobot Commented
jitu said:
JAX-RS resources need not have zero-org constructors. See chapter 3.1.2. But it is odd that it doesn't specify any other requirements.

From the definition, the following is allowed (but it cannot be instantiated)

@WebSocketEndpoint
abstract class A {
public A() {
}
}

@glassfishrobot
Copy link
Author

@glassfishrobot Commented
dannycoward said:
OK. We certainly can't have non-public abstract classes.

"The class must be public, concrete, and have a public no-args constructor. The class may or may not be final, and may or may not have final methods."

Let me know if there are other types you think we have to allow for v 1.0 as a priority.

@glassfishrobot
Copy link
Author

@glassfishrobot Commented
Marked as fixed on Monday, February 4th 2013, 4:56:12 pm

@glassfishrobot
Copy link
Author

@glassfishrobot Commented
dannycoward said:
What I proposed has been out to the expert group with no comment, so I am closing this out.

We might look at expanding the possibilities in the next version, but I think this is clear and simple for this version.

@glassfishrobot
Copy link
Author

@glassfishrobot Commented
This issue was imported from java.net JIRA WEBSOCKET_SPEC-53

@glassfishrobot
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant