isEmpty instead of size

eclipse-emf-parsley · Nov 17, 2023 · c53fd03 · c53fd03
1 parent ff0fc30
commit c53fd03
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/...e.emf.parsley.common/src/org/eclipse/emf/parsley/resource/ValidateBeforeSaveStrategy.java b/...e.emf.parsley.common/src/org/eclipse/emf/parsley/resource/ValidateBeforeSaveStrategy.java
@@ -42,6 +42,6 @@ public boolean save(Resource resource) throws IOException {
 	}
 
 	protected boolean precondition(Resource resource) {
-		return validationRunner.validate(resource, issueReporter).size() == 0;
+		return validationRunner.validate(resource, issueReporter).isEmpty();
 	}
 }
diff --git a/...clipse.emf.parsley.common/src/org/eclipse/emf/parsley/validation/DialogErrorReporter.java b/...clipse.emf.parsley.common/src/org/eclipse/emf/parsley/validation/DialogErrorReporter.java
@@ -34,7 +34,7 @@ public class DialogErrorReporter implements IssueReporter {
 	public List<Diagnostic> report(Diagnostic diagnostic) {
 		List<Diagnostic> errors = Lists.newArrayList(diagnosticUtil.errors(diagnostic));
 
-		if (errors.size() > 0) {
+		if (!errors.isEmpty()) {
 			DiagnosticDialog.open(PlatformUI.getWorkbench().getActiveWorkbenchWindow().getShell(), "Validation Errors",
 					"Problems encountered during validation", diagnostic, Diagnostic.ERROR);
 		}

diff --git a/...lipse.emf.parsley.junit4/src/org/eclipse/emf/parsley/junit4/util/LogAppenderTestRule.java b/...lipse.emf.parsley.junit4/src/org/eclipse/emf/parsley/junit4/util/LogAppenderTestRule.java
@@ -111,7 +111,7 @@ protected String eventsToString() {
 
 	public void assertEmpty() {
 		Assert.assertTrue("Found messages: " + eventsToString(),
-			logListener.getEvents().size() == 0
+			logListener.getEvents().isEmpty()
 		);
 	}