From 933a848055cc6a05a53928de560ecf918829161f Mon Sep 17 00:00:00 2001 From: alexandershpak Date: Thu, 13 Dec 2018 17:41:00 +0300 Subject: [PATCH] bug(fix) CLI diagnostics: Incorrect error message is displayed when user try to get strace-info --- src/helpers/error-messages.js | 1 + src/services/diagnostic-service.js | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/src/helpers/error-messages.js b/src/helpers/error-messages.js index c107044c0..6ab703477 100644 --- a/src/helpers/error-messages.js +++ b/src/helpers/error-messages.js @@ -23,6 +23,7 @@ module.exports = { INVALID_FOG_NODE_UUID: 'Invalid ioFog UUID {}', INVALID_USER_EMAIL: 'Invalid user email', INVALID_MICROSERVICE_UUID: "Invalid microservice UUID '{}'", + INVALID_MICROSERVICE_STRACE: "Strace data for this microservice not found", INVALID_VOLUME_MAPPING_UUID: "Invalid volume mapping id '{}'", ACTIVATION_CODE_NOT_FOUND: 'Activation code not found', INVALID_OLD_PASSWORD: 'Old password is incorrect', diff --git a/src/services/diagnostic-service.js b/src/services/diagnostic-service.js index d2aeeb6c0..741f122f4 100644 --- a/src/services/diagnostic-service.js +++ b/src/services/diagnostic-service.js @@ -56,6 +56,10 @@ const getMicroserviceStraceData = async function (id, data, user, isCLI, transac } const straceData = await StraceDiagnosticManager.findOne({microserviceUuid: id}, transaction); + if (!straceData) { + throw new Errors.NotFoundError(AppHelper.formatMessage(ErrorMessages.INVALID_MICROSERVICE_STRACE, id)) + } + const dir = config.get('Diagnostics:DiagnosticDir') || 'diagnostics'; const filePath = dir + '/' + id;