Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[null analysis] animal instanceof Dog dog fails to assume dog as @NonNull #350

Closed
mickaelistria opened this issue Aug 26, 2022 · 3 comments
Closed

[null analysis] animal instanceof Dog dog fails to assume dog as @NonNull #350

mickaelistria opened this issue Aug 26, 2022 · 3 comments

Comments

@mickaelistria
Copy link
Contributor

named instance of (eg animal instanceof Dog dog) do not assume the new variable (dog here) is @NonNull. It leads to false warning reports with null analysis.
@iloveeclipse
Copy link
Member

@stephan-herrmann : do you have some time/interest?

@stephan-herrmann
Copy link
Contributor

Interest? Sure. Time? Let's see.
Might also be a good learning issue for someone new to this aspect of the code :)

BTW, we already have two bugs for this:

mickaelistria added a commit to mickaelistria/eclipse.jdt.core that referenced this issue Aug 29, 2022
@mickaelistria
[null] Assume instanceof local declaration non-null
1980303 
eclipse-jdt#350
@mickaelistria mickaelistria mentioned this issue Aug 29, 2022
Merged
3 tasks
mickaelistria added a commit to mickaelistria/eclipse.jdt.core that referenced this issue Aug 29, 2022
@mickaelistria
[null] Assume instanceof local declaration non-null
5dbb0e0 
eclipse-jdt#350
mickaelistria added a commit to mickaelistria/eclipse.jdt.core that referenced this issue Aug 29, 2022
@mickaelistria
[null] Assume instanceof local declaration non-null
c9047f3 
eclipse-jdt#350
mickaelistria added a commit to mickaelistria/eclipse.jdt.core that referenced this issue Aug 30, 2022
@mickaelistria
[null] Assume instanceof local declaration non-null
c4e45a7 
eclipse-jdt#350
mickaelistria added a commit to mickaelistria/eclipse.jdt.core that referenced this issue Aug 30, 2022
@mickaelistria
[null] Assume instanceof local declaration non-null
a24feb9 
eclipse-jdt#350
mickaelistria added a commit to mickaelistria/eclipse.jdt.core that referenced this issue Aug 31, 2022
@mickaelistria
[null] Assume instanceof local declaration non-null
8115567 
eclipse-jdt#350
mickaelistria added a commit to mickaelistria/eclipse.jdt.core that referenced this issue Aug 31, 2022
@mickaelistria
[null] Assume instanceof local declaration non-null
e3dde76 
eclipse-jdt#350
mickaelistria added a commit to mickaelistria/eclipse.jdt.core that referenced this issue Sep 7, 2022
@mickaelistria
[null] Assume instanceof local declaration non-null
561d2e6 
eclipse-jdt#350
mickaelistria added a commit to mickaelistria/eclipse.jdt.core that referenced this issue Sep 8, 2022
@mickaelistria
[null] Assume instanceof local declaration non-null
374186a 
eclipse-jdt#350
github-actions bot pushed a commit to mickaelistria/eclipse.jdt.core that referenced this issue Sep 13, 2022
@mickaelistria @stephan-herrmann
[null] Assume instanceof local declaration non-null
50a820a 
eclipse-jdt#350
stephan-herrmann pushed a commit that referenced this issue Sep 13, 2022
@mickaelistria
[null] Assume instanceof local declaration non-null (#351)
36ac8f4 
#350
jarthana pushed a commit to jarthana/eclipse.jdt.core that referenced this issue Sep 21, 2022
@mickaelistria @jarthana
[null] Assume instanceof local declaration non-null (eclipse-jdt#351)
e63323b 
eclipse-jdt#350
@stephan-herrmann
Copy link
Contributor

GitHub forgot to close this issue, when #351 got merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mickaelistria @iloveeclipse @stephan-herrmann