Bug 573552 - Missing warning for diamond operator #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For method invocations, the allocation expression get its expected type soon enough. So, we should wait till it's available.
|
There is some duplication of code, but given this is only two lines of code and avoiding this might involve some refactoring, I will go with this. |
subyssurendran666
pushed a commit
to subyssurendran666/eclipse.jdt.core
that referenced
this pull request
Jul 18, 2023
For method invocations, the allocation expression doesn't get its expected type soon enough. So, we should wait till it's available and report the error if applicable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For method invocations, the allocation expression does not get its expected type soon enough. So, we should wait till it's available.
What it does
How to test
Author checklist