Bug 501652 - [1.8][impl] inconsistent call to ITypeAnnotationWalker.toSupertype(..)

[stephan-herrmann]

From https://bugs.eclipse.org/501652

What it does

Pass the correct type name (super interface not super class)

How to test

Actually this cannot be tested, because

• "normal" type annotation walkers rely only on the short index argument
• only DispatchingAnnotationWalker uses the char[] superTypeSignature signature to weave in information from eea
  • eea - being specialized for null annotations - use super type information only for type arguments, since it doesn't make sense to say implements @Nullable IFoo.
  • since the super type must have type arguments for eea to make sense here,BTB.cachePartsFrom() will find non-null binaryType.getGenericSignature()
• To challenge the wrongly passed type name, these two would have to coincide which cannot happen at the same time:
  • the super type must be generic to host type argument annotations in eea
  • the super type must be non-generic for BTB.cachePartsFrom() to enter the code branch in question.

Still, cleaning up the code makes sense simply to avoid future confusion :)