From a1369a3ee3f657370bba5aa55be4c0f612468a29 Mon Sep 17 00:00:00 2001 From: Yan Zhang Date: Thu, 7 Nov 2019 16:52:50 +0800 Subject: [PATCH] create issue for malformed comparator Signed-off-by: Yan Zhang --- .../jdt/ls/core/internal/handlers/CodeActionHandler.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/CodeActionHandler.java b/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/CodeActionHandler.java index 45a8c92eec..733d3f5f7e 100644 --- a/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/CodeActionHandler.java +++ b/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/CodeActionHandler.java @@ -145,7 +145,7 @@ public List> getCodeActionCommands(CodeActionParams } } - // TODO (Yan): below comparator seldomly compares relavance, it returns early if code action kind is different. + // TODO (Yan): See https://github.com/eclipse/eclipse.jdt.ls/issues/1250 proposals.sort(new ChangeCorrectionProposalComparator()); // TODO (Yan): below block post-filters the proposals by CodeActionKind, can be removed in future if all above processors are doing right things.