Always close file descriptors when deamonised.#2708
Closed
ckoehne wants to merge 1 commit intoeclipse-mosquitto:masterfrom
Closed
Always close file descriptors when deamonised.#2708ckoehne wants to merge 1 commit intoeclipse-mosquitto:masterfrom
ckoehne wants to merge 1 commit intoeclipse-mosquitto:masterfrom
Conversation
Assertions can be removed in debug builds. Fixes: f588075 Signed-off-by: Corvin Köhne <corvink@FreeBSD.org>
Contributor
|
Thank you, you're quite right. I've fixed this in a slightly different way so the return values aren't ignored. |
ralight
added a commit
that referenced
this pull request
Dec 16, 2022
This could occur when built with assertions removed. Closes #2708. Thanks to ckoehne.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assertions can be removed in debug builds.
Fixes: f588075
Signed-off-by: Corvin Köhne corvink@FreeBSD.org
Thank you for contributing your time to the Mosquitto project!
Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.
Then please check the following list of things we ask for in your pull request:
make testwith your changes locally?