Add comment on where _recompilationMethodInfo is freed #8082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CompilationInfoPerThreadRemote::_recompilationMethodInfo` was allocated in the persistent memory in `CompilationInfoPerThreadRemote::processEntry()`. `_recompilationMethodInfo` is related to per compilation. Ideally it should be allocated in the scratch memory. However the scratch memory is part of the compilation object which has not been created when the entry is being processed. During the compilation, `_recompilationMethodInfo` is passed to `J9::Recompilation::_methodInfo`, which will get freed in `populateBodyInfo()` when creating the method meta data during the compilation. Since `_recompilationMethodInfo` is already freed in `populateBodyInfo()`, no need to free it at the end of the compilation in `CompilationInfoPerThreadRemote::processEntry()`. Closes eclipse-openj9#7988 Signed-off-by: a7ehuo <Annabelle.Huo@ibm.com>
a7ehuo
changed the title
|
Jenkins test sanity plinux jdk8 |
|
Jenkins compile xlinuxjit jdk8 |
|
This is a very simple commit composed of one comment and two simple and safe assignments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompilationInfoPerThreadRemote::_recompilationMethodInfowas allocatedin the persistent memory in
CompilationInfoPerThreadRemote::processEntry()._recompilationMethodInfois related to per compilation. Ideally it should beallocated in the scratch memory. However the scratch memory is part of
the compilation object which has not been created when the entry is being processed.
During the compilation,
_recompilationMethodInfois passedto
J9::Recompilation::_methodInfo, which will get freed inpopulateBodyInfo()when creating the method meta data during the compilation.
Since
_recompilationMethodInfois already freed inpopulateBodyInfo(),no need to free it at the end of the compilation in
CompilationInfoPerThreadRemote::processEntry().Closes #7988
Signed-off-by: a7ehuo Annabelle.Huo@ibm.com