Bug 564328 API revision | conditions | rethink key interfaces #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- contract tests for all the Condition descriptive interfaces - `TemporaryTest` is deleted as there is the first true and not-abstract test appeared - `LicensingVersion` is deprecated in the favor of new Condition implementation Signed-off-by: elena.parovyshnaya <elena.parovyshnaya@gmail.com>
- add ending new lines Signed-off-by: elena.parovyshnaya <elena.parovyshnaya@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
=========================================
+ Coverage 9.66% 9.72% +0.05%
=========================================
Files 575 576 +1
Lines 14966 14977 +11
Branches 1168 1168
=========================================
+ Hits 1446 1456 +10
- Misses 13482 13483 +1
Partials 38 38
Continue to review full report at Codecov.
|
ruspl-afed
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TemporaryTestis deleted as there is the first true andnot-abstract test appeared
LicensingVersionis deprecated in the favor of new Conditionimplementation
Signed-off-by: elena.parovyshnaya elena.parovyshnaya@gmail.com