Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 564328 API revision | conditions | rethink key interfaces #253

Merged
merged 2 commits into from Jun 18, 2020

Conversation

eparovyshnaya
Copy link
Contributor

tests for base condition descriptive API implementation

Signed-off-by: elena.parovyshnaya elena.parovyshnaya@gmail.com

  tests for base condition descriptive API implementation

Signed-off-by: elena.parovyshnaya <elena.parovyshnaya@gmail.com>
  add license header

Signed-off-by: elena.parovyshnaya <elena.parovyshnaya@gmail.com>
@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #253 into master will increase coverage by 1.84%.
The diff coverage is 88.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
+ Coverage    9.72%   11.56%   +1.84%     
==========================================
  Files         576      592      +16     
  Lines       14977    15161     +184     
  Branches     1168     1168              
==========================================
+ Hits         1456     1754     +298     
+ Misses      13483    13364     -119     
- Partials       38       43       +5     
Impacted Files Coverage Δ
...ase/conditions/BaseEvaluationInstructionsTest.java 20.00% <20.00%> (ø)
.../base/conditions/BaseValidityPeriodClosedTest.java 20.00% <20.00%> (ø)
...ditions/contract/BaseMatchingRuleContractTest.java 20.00% <20.00%> (ø)
...ic/internal/base/conditions/BaseConditionTest.java 38.46% <38.46%> (ø)
...base/conditions/MatchingRuleForIdentifierTest.java 90.00% <90.00%> (ø)
...al/base/conditions/MatchingRuleCompatibleTest.java 100.00% <100.00%> (ø)
...al/base/conditions/MatchingRuleEquivalentTest.java 100.00% <100.00%> (ø)
...ase/conditions/MatchingRuleGreaterOrEqualTest.java 100.00% <100.00%> (ø)
...ernal/base/conditions/MatchingRulePerfectTest.java 100.00% <100.00%> (ø)
...tions/contract/BaseValidityPeriodContractTest.java 100.00% <100.00%> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c223f9...5037e78. Read the comment docs.

@eparovyshnaya eparovyshnaya merged commit 22c754d into master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants