Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 564328 API revision | conditions | rethink key interfaces #255

Merged
merged 2 commits into from Jun 18, 2020

Conversation

eparovyshnaya
Copy link
Contributor

  • revised versions of ConditionMiner and registry are added
  • Framework interface is extended with the corresponding supplier
  • Framework implementations follow the changes

side work:

  • ResolvedRequirements interface license header is fixed

Signed-off-by: elena.parovyshnaya elena.parovyshnaya@gmail.com

side work:
  - revised versions of `ConditionMiner` and registry  are added
  - `Framework` interface is extended with the corresponding supplier
  - `Framework` implementations follow the changes
  - `ResolvedRequirements` interface license header is fixed

Signed-off-by: elena.parovyshnaya <elena.parovyshnaya@gmail.com>
 - add missed license header! again!!11

Signed-off-by: elena.parovyshnaya <elena.parovyshnaya@gmail.com>
@eparovyshnaya
Copy link
Contributor Author

Closes 564328

@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #255 into master will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
- Coverage   11.56%   11.56%   -0.01%     
==========================================
  Files         592      592              
  Lines       15161    15163       +2     
  Branches     1168     1168              
==========================================
  Hits         1754     1754              
- Misses      13364    13366       +2     
  Partials       43       43              
Impacted Files Coverage Δ
...nternal/api/requirements/ResolvedRequirements.java 0.00% <ø> (ø)
.../passage/lic/base/tests/LicensingVersionsTest.java 100.00% <ø> (ø)
.../passage/lic/internal/base/SabotagedFramework.java 60.00% <33.33%> (-40.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a579471...5118b16. Read the comment docs.

@eparovyshnaya eparovyshnaya merged commit ae79fae into master Jun 18, 2020
@eparovyshnaya eparovyshnaya deleted the 564328 branch June 18, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants