564420 [Passage] API revision | conditions | move HC condition miner to new interfaces #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- port `ConditionTransport` to new `Condition` interface Signed-off-by: elena.parovyshnaya <elena.parovyshnaya@gmail.com>
- invite `ConditionMiningException` to handle all the difficulties actual mining faces Signed-off-by: elena.parovyshnaya <elena.parovyshnaya@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #257 +/- ##
==========================================
- Coverage 11.56% 11.56% -0.01%
==========================================
Files 592 593 +1
Lines 15163 15167 +4
Branches 1168 1168
==========================================
Hits 1754 1754
- Misses 13366 13370 +4
Partials 43 43
Continue to review full report at Codecov.
|
ruspl-afed
reviewed
Jun 21, 2020
...sage.lic.api/src/org/eclipse/passage/lic/internal/api/conditions/mining/MinedConditions.java
Show resolved
Hide resolved
- document exception firing during condition mining process Signed-off-by: elena.parovyshnaya <elena.parovyshnaya@gmail.com>
eparovyshnaya
changed the title
ruspl-afed
approved these changes
Jun 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConditionMiningExceptionto handle all the difficultiesactual mining faces
ConditionTransportto newConditioninterface