Bug 564420 move HC condition miner to new interfaces #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make `ConditionTransport` interface a `Service` with a dedicated registry - invite `ContentType` as a `ServiceId` - create contract tests for `ServiceId`, test both implementations Signed-off-by: elena.parovyshnaya <elena.parovyshnaya@gmail.com>
ruspl-afed
approved these changes
Jun 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
+ Coverage 11.65% 11.78% +0.13%
==========================================
Files 594 598 +4
Lines 15193 15218 +25
Branches 1172 1172
==========================================
+ Hits 1770 1794 +24
+ Misses 13377 13376 -1
- Partials 46 48 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConditionTransportinterface aServicewith a dedicatedregistry
ContentTypeas aServiceIdServiceId, test both implementationsSigned-off-by: elena.parovyshnaya elena.parovyshnaya@gmail.com