Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 564420 move HC condition miner to new interfaces #261

Merged
merged 5 commits into from Jun 21, 2020
Merged

Conversation

eparovyshnaya
Copy link
Contributor

  • implement ConditionTransport service for application/json content
    type
  • deprecate corresponding units relying on the previous version of
    interfaces

Signed-off-by: elena.parovyshnaya elena.parovyshnaya@gmail.com

 - implement `ConditionTransport` service for `application/json` content
type
 - deprecate corresponding units relying on the previous version of
interfaces

Signed-off-by: elena.parovyshnaya <elena.parovyshnaya@gmail.com>
 - make piece with version-against-baseline check

Signed-off-by: elena.parovyshnaya <elena.parovyshnaya@gmail.com>
 - move version one service step forward

Signed-off-by: elena.parovyshnaya <elena.parovyshnaya@gmail.com>
 - expand deprecation and fix comments

Signed-off-by: elena.parovyshnaya <elena.parovyshnaya@gmail.com>
@codecov
Copy link

codecov bot commented Jun 21, 2020

Codecov Report

Merging #261 into master will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
- Coverage   11.78%   11.74%   -0.05%     
==========================================
  Files         598      604       +6     
  Lines       15218    15277      +59     
  Branches     1172     1172              
==========================================
  Hits         1794     1794              
- Misses      13376    13435      +59     
  Partials       48       48              
Impacted Files Coverage Δ
...sage/lic/internal/json/JsonConditionTransport.java 0.00% <ø> (ø)
...lipse/passage/lic/internal/json/JsonTransport.java 0.00% <0.00%> (ø)
...ic/internal/json/LicensingConditionAggregator.java 0.00% <ø> (ø)
...age/lic/internal/json/LicensingConditionMixIn.java 0.00% <ø> (ø)
...lic/internal/json/LicensingConfigurationMixIn.java 0.00% <ø> (ø)
...internal/json/tobemoved/ConditionDeserializer.java 0.00% <0.00%> (ø)
...age/lic/internal/json/tobemoved/ConditionPack.java 0.00% <0.00%> (ø)
...c/internal/json/tobemoved/ConditionSerializer.java 0.00% <0.00%> (ø)
...nternal/json/tobemoved/JsonConditionTransport.java 0.00% <0.00%> (ø)
.../lic/internal/json/tobemoved/JsonObjectMapper.java 0.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88ad53e...8cdd47f. Read the comment docs.

 - comments to further work direction

Signed-off-by: elena.parovyshnaya <elena.parovyshnaya@gmail.com>
@eparovyshnaya eparovyshnaya merged commit df62d74 into master Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants