Bug 564420 conditions | move HC condition miner to new interfaces #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- compose a test for RemoteConditionsRequest url composition Signed-off-by: elena.parovyshnaya <elena.parovyshnaya@gmail.com>
- cover the rest of mining request attributes with NamedData: User (yet temporary) and ContentType - extend RemoteConditionsRequest test Signed-off-by: elena.parovyshnaya <elena.parovyshnaya@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
==========================================
+ Coverage 11.92% 12.42% +0.50%
==========================================
Files 629 631 +2
Lines 15570 15753 +183
Branches 1179 1198 +19
==========================================
+ Hits 1856 1958 +102
- Misses 13669 13751 +82
+ Partials 45 44 -1
Continue to review full report at Codecov.
|
- stick to particular versions for all the required bundles Signed-off-by: elena.parovyshnaya <elena.parovyshnaya@gmail.com>
- fix ContentType usages according to the class signature change Signed-off-by: elena.parovyshnaya <elena.parovyshnaya@gmail.com>
ruspl-afed
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NamedData:User(yet temporary) andContentType. Corresponding public string constants are deprecated with proper notes.Signed-off-by: elena.parovyshnaya elena.parovyshnaya@gmail.com