Bug 565012 - API revision | permission | OshiPermissionEmitter #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rework inspection interface - move public constant literals to proper cover-classes under `base` implementation bundle Signed-off-by: elena.parovyshnaya <elena.parovyshnaya@gmail.com>
ruspl-afed
approved these changes
Jul 11, 2020
There was a problem hiding this comment.
Looks much better than a set of public constants, thanks @eparovyshnaya !
Codecov Report
@@ Coverage Diff @@
## master #304 +/- ##
==========================================
+ Coverage 26.33% 26.60% +0.26%
==========================================
Files 713 720 +7
Lines 16818 16912 +94
Branches 1211 1213 +2
==========================================
+ Hits 4429 4499 +70
- Misses 12249 12267 +18
- Partials 140 146 +6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
baseimplementation bundle
Signed-off-by: elena.parovyshnaya elena.parovyshnaya@gmail.com