Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully reflect merge of pde.build in PDE's Oomph setup #71

Merged
merged 2 commits into from May 4, 2022

Conversation

HannesWell
Copy link
Member

This PR inlines the PDE Core Project and adds a PDE Build Working-Set.
Furthermore it removes the 'core' element from ids.

Just like for the renaming of the project from PDE UI to PDE Core we have to provide a way to inform users that they have to update the Project-stream referenced in their workspace setup. Otherwise the setup is broken.
@merks can you please review this?

@merks merks merged commit d855890 into eclipse-pde:master May 4, 2022
3 checks passed
@merks
Copy link
Contributor

merks commented May 4, 2022

FYI, I had to commit this as well because the SDK configuration references the refactored project too.

eclipse-platform/eclipse.platform.releng.aggregator@41ba8b7

@HannesWell HannesWell deleted the improvePDEsetup branch May 4, 2022 16:38
@HannesWell
Copy link
Member Author

Thanks for taking care of that!

@merks
Copy link
Contributor

merks commented May 4, 2022

BTW, with my recent changes to the aggregator setup, these things are visible now within projects:

image

Making it easier to notice and to change.

@HannesWell
Copy link
Member Author

That's handy! Until now I had to import them manually.

What would be even more useful to test changes of the eclipse-sdk-prereqs.start would be if the content of that file would also be included into the activated modular target-platform if present. At the moment I manually added a 'target'-type target referring to that file (but interestingly that additional content stays even when I re-run the setup, which is good in my case).

@merks
Copy link
Contributor

merks commented May 6, 2022

In the past such a thing was not possible , but now in principle, it could be composed though some people have trouble getting that to work and I don't have time to make such a thing work:

https://www.eclipse.org/forums/index.php/mv/msg/1110731/1852217/#msg_1852217

It's currently a simple matter of switching the active target in the preferences (and then wait and wait for all the bundles that you already have downloaded to be downloaded yet again)...

@HannesWell
Copy link
Member Author

In the past such a thing was not possible , but now in principle, it could be composed though some people have trouble getting that to work and I don't have time to make such a thing work:

https://www.eclipse.org/forums/index.php/mv/msg/1110731/1852217/#msg_1852217

Since I have a relativly simple workaround for my problem, I'm fine at the moment. :)

It's currently a simple matter of switching the active target in the preferences (and then wait and wait for all the bundles that you already have downloaded to be downloaded yet again)...

Yep, I think we should consider to use the shared Bundle pool in PDE for the Target-Platform resolution, if one is available.
I have the intention to try that in the future (did not have the time yet) or do you think there are general things that make it impossible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants