diff --git a/eclipse.platform.releng/bundles/org.eclipse.test.performance/.settings/org.eclipse.jdt.core.prefs b/eclipse.platform.releng/bundles/org.eclipse.test.performance/.settings/org.eclipse.jdt.core.prefs index 379564200ae..bdb89d64c20 100644 --- a/eclipse.platform.releng/bundles/org.eclipse.test.performance/.settings/org.eclipse.jdt.core.prefs +++ b/eclipse.platform.releng/bundles/org.eclipse.test.performance/.settings/org.eclipse.jdt.core.prefs @@ -32,7 +32,7 @@ org.eclipse.jdt.core.compiler.problem.APILeak=warning org.eclipse.jdt.core.compiler.problem.annotatedTypeArgumentToUnannotated=info org.eclipse.jdt.core.compiler.problem.annotationSuperInterface=warning org.eclipse.jdt.core.compiler.problem.assertIdentifier=error -org.eclipse.jdt.core.compiler.problem.autoboxing=info +org.eclipse.jdt.core.compiler.problem.autoboxing=ignore org.eclipse.jdt.core.compiler.problem.comparingIdentical=warning org.eclipse.jdt.core.compiler.problem.deadCode=warning org.eclipse.jdt.core.compiler.problem.deprecation=warning diff --git a/eclipse.platform.releng/bundles/org.eclipse.test.performance/src/org/eclipse/test/internal/AwtScreenshot.java b/eclipse.platform.releng/bundles/org.eclipse.test.performance/src/org/eclipse/test/internal/AwtScreenshot.java index ee7906dc126..b9c4628465b 100644 --- a/eclipse.platform.releng/bundles/org.eclipse.test.performance/src/org/eclipse/test/internal/AwtScreenshot.java +++ b/eclipse.platform.releng/bundles/org.eclipse.test.performance/src/org/eclipse/test/internal/AwtScreenshot.java @@ -93,8 +93,15 @@ public static void dumpAwtScreenshot(String screenshotFile) { processBuilder.environment().put("AWT_TOOLKIT", "CToolkit"); } Process process = processBuilder.start(); - new StreamForwarder(process.getErrorStream(), System.out).start(); - new StreamForwarder(process.getInputStream(), System.out).start(); + + @SuppressWarnings("resource") // never close process streams + InputStream errorStream = process.getErrorStream(); + + @SuppressWarnings("resource") // never close process streams + InputStream inputStream = process.getInputStream(); + + new StreamForwarder(errorStream, System.out).start(); + new StreamForwarder(inputStream, System.out).start(); long end = System.currentTimeMillis() + TIMEOUT_SECONDS * 1000; boolean done = false; do { diff --git a/eclipse.platform.releng/bundles/org.eclipse.test/src/org/eclipse/test/AbstractJUnitResultFormatter.java b/eclipse.platform.releng/bundles/org.eclipse.test/src/org/eclipse/test/AbstractJUnitResultFormatter.java index de8c659c80c..4aa78b8773a 100644 --- a/eclipse.platform.releng/bundles/org.eclipse.test/src/org/eclipse/test/AbstractJUnitResultFormatter.java +++ b/eclipse.platform.releng/bundles/org.eclipse.test/src/org/eclipse/test/AbstractJUnitResultFormatter.java @@ -129,8 +129,9 @@ Reader getSysErrReader() throws IOException { * @throws IOException If any I/O problem occurs during writing the data */ void writeSysOut(Writer writer) throws IOException { - Objects.requireNonNull(writer, "Writer cannot be null"); - writeFrom(this.sysOutStore, writer); + @SuppressWarnings("resource") // requireNonNull just returns first argument + Writer w = Objects.requireNonNull(writer, "Writer cannot be null"); + writeFrom(this.sysOutStore, w); } /** @@ -141,8 +142,9 @@ void writeSysOut(Writer writer) throws IOException { * @throws IOException If any I/O problem occurs during writing the data */ void writeSysErr(Writer writer) throws IOException { - Objects.requireNonNull(writer, "Writer cannot be null"); - writeFrom(this.sysErrStore, writer); + @SuppressWarnings("resource") // requireNonNull just returns first argument + Writer w = Objects.requireNonNull(writer, "Writer cannot be null"); + writeFrom(this.sysErrStore, w); } static Optional traverseAndFindTestClass(TestPlan testPlan, TestIdentifier testIdentifier) {