IllegalArgumentException in HTMLTextPresenter during quickfix

[jukzi]

don't know how it happend, found in the logfile:

eclipse.buildId=4.35.0.I20250102-1800
java.version=22.0.2
java.vendor=Eclipse Adoptium
BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=de_DE
Command-line arguments:  -os win32 -ws win32 -arch x86_64 -data C:\Users\jkubitz\platform-2025-01-03_2\ws

org.eclipse.ui
Error
Fri Jan 03 11:11:00 CET 2025
Unhandled event loop exception

java.lang.IllegalArgumentException: Argument not valid
	at org.eclipse.swt.SWT.error(SWT.java:4913)
	at org.eclipse.swt.SWT.error(SWT.java:4847)
	at org.eclipse.swt.SWT.error(SWT.java:4818)
	at org.eclipse.swt.graphics.TextStyle.<init>(TextStyle.java:189)
	at org.eclipse.swt.custom.StyleRange.<init>(StyleRange.java:68)
	at org.eclipse.jface.internal.text.html.HTMLTextPresenter.updatePresentation(HTMLTextPresenter.java:170)
	at org.eclipse.jface.text.DefaultInformationControl.setInformation(DefaultInformationControl.java:341)
	at org.eclipse.jface.text.AbstractInformationControlManager.internalShowInformationControl(AbstractInformationControlManager.java:1153)
	at org.eclipse.jface.text.AbstractInformationControlManager.presentInformation(AbstractInformationControlManager.java:1120)
	at org.eclipse.jface.text.AbstractInformationControlManager.setInformation(AbstractInformationControlManager.java:431)
	at org.eclipse.jface.text.contentassist.AdditionalInfoController.computeInformation(AdditionalInfoController.java:567)
	at org.eclipse.jface.text.AbstractInformationControlManager.doShowInformation(AbstractInformationControlManager.java:1101)
	at org.eclipse.jface.text.AbstractInformationControlManager.showInformation(AbstractInformationControlManager.java:1091)
	at org.eclipse.jface.text.contentassist.AdditionalInfoController.showInformation(AdditionalInfoController.java:541)
	at org.eclipse.jface.text.contentassist.AdditionalInfoController$1.showInformation(AdditionalInfoController.java:478)
	at org.eclipse.jface.text.contentassist.AdditionalInfoController$Timer.lambda$1(AdditionalInfoController.java:362)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:40)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:132)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4084)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3700)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1151)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1042)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:153)
	at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:663)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:570)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:173)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:178)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:208)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:143)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:109)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:439)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:271)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:668)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:605)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1481)

org.eclipse.swt.graphics.TextLayout.getStyle(int) is documented to possibly return null but used unconconditionally
code from 2937090a3de9dda30f24ea5afbdc6e6f22965afb @tsmaeder @mickaelistria

[jukzi]

To reproduce: Press ctrl+1 (quickfix) in line 5 (missing imports):

package my;

public class A {
	{
		List<CompletableFuture<Void>> futures = new ArrayList<>();

	}
}

[merks]

Nice work on creating a simple reproduction. 👍

[jukzi]

Even though one could just add a null check in HTMLTextPresenter, it seems to be that the null value is not intentional here but a regression of #1320 now resolving a wrong range.
@deepika-u @HeikoKlare can you please check?

[jukzi]

a NPE check in HTMLTextPresenter would be wrong as org.eclipse.swt.graphics.TextLayout.getRanges() tries to return only ranges with style!= null. The client can not expect that that TextLayoutgetStyle(range) for such a range now returns a null value. SWT needs to be fixed. moving issue.

[deepika-u]

oh oh! Let me check on TextLayout.getRanges() and update here.

[jukzi]

If there is no fix soon i propose to revert the change until a fix is found, as this error happens really often.

[deepika-u]

If there is no fix soon i propose to revert the change until a fix is found, as this error happens really often.

I am working on it, will update on it. Is it really effecting any scenario which is not working now and working earlier? Apart from seeing the error in the .log and its frequency.

[jukzi]

Apart from seeing the error in the .log and its frequency.

only that - but that pollutes my logs so much that its hard to spot other issues.