Skip to content

Revert "Corrected TextLayout to produce right number of lines when '\r\n' sequence comes." #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2025
Merged

Revert "Corrected TextLayout to produce right number of lines when '\r\n' sequence comes." #1732

merged 1 commit into from
Jan 17, 2025

Conversation

@jukzi
Copy link
Contributor

@jukzi jukzi commented Jan 16, 2025

Reverts #1320

IllegalArgumentException in HTMLTextPresenter during quickfix
#1714

@jukzi jukzi requested a review from HeikoKlare January 16, 2025 10:07
@jukzi jukzi linked an issue Jan 16, 2025 that may be closed by this pull request
IllegalArgumentException in HTMLTextPresenter during quickfix #1714
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025

Test Results

   494 files  ±0     494 suites  ±0   8m 13s ⏱️ - 3m 3s
 4 323 tests  - 1   4 305 ✅  - 1   18 💤 ±0  0 ❌ ±0 
16 530 runs   - 4  16 382 ✅  - 4  148 💤 ±0  0 ❌ ±0 

Results for commit c8f56c5. ± Comparison against base commit e0b4fe9.

This pull request removes 1 test. 
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_graphics_TextLayout ‑ test_getLineCount

@jukzi
Copy link
Contributor Author

jukzi commented Jan 16, 2025

cc @deepika, ok to revert until you found a solution?

@jukzi
Copy link
Contributor Author

jukzi commented Jan 17, 2025

@eclipse-platform/eclipse-platform-project-leads please revert regression

HeikoKlare
HeikoKlare reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepika-u will you be able to propose a fix for #1714 today?
Otherwise, reverting the change producing the regressions for M2 is, in my opinion, the right thing to do. Even though it unfortunately introduces the fixed issue #184 again (which should be reopened after merging this revert).

@deepika-u
Copy link
Contributor

deepika-u commented Jan 17, 2025 •
edited
Loading

Yeah please go ahead with a revert. I have a fix but need some more time to test and finalize on the fix before it can be proposed as a pr.

@jukzi jukzi merged commit 6e219e1 into master Jan 17, 2025
10 of 15 checks passed
@jukzi jukzi deleted the revert-1320-fix_for_issue184 branch January 17, 2025 10:14
@akurtakov akurtakov mentioned this pull request Jan 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HeikoKlare HeikoKlare HeikoKlare left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IllegalArgumentException in HTMLTextPresenter during quickfix

4 participants

@jukzi @deepika-u @HeikoKlare